Problem: tx receipt don't contain events#93
Merged
Conversation
Solution: - convert tx hash when query logs - transaction index in logs start from 0
yihuang
requested review from
devashishdxt and
thomas-nguy
and removed request for
a team
September 22, 2021 04:12
11 tasks
Codecov Report
@@ Coverage Diff @@
## main #93 +/- ##
==========================================
+ Coverage 21.51% 26.15% +4.64%
==========================================
Files 27 32 +5
Lines 1729 2183 +454
==========================================
+ Hits 372 571 +199
- Misses 1324 1575 +251
- Partials 33 37 +4
Continue to review full report at Codecov.
|
thomas-nguy
approved these changes
Sep 22, 2021
thomas-nguy
left a comment
Collaborator
There was a problem hiding this comment.
lgtm
(please fix the lint issue before merging)
yihuang
force-pushed
the
remove-tx-logs
branch
from
September 22, 2021 04:32
386a244 to
532b18a
Compare
yihuang
force-pushed
the
remove-tx-logs
branch
from
September 22, 2021 04:38
532b18a to
e1b0994
Compare
yihuang
force-pushed
the
remove-tx-logs
branch
from
September 22, 2021 05:30
464b7a7 to
98bca43
Compare
13 tasks
This was referenced Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)