Skip to content

Problem: tx receipt don't contain events#93

Merged
yihuang merged 4 commits into
crypto-org-chain:mainfrom
yihuang:remove-tx-logs
Sep 22, 2021
Merged

Problem: tx receipt don't contain events#93
yihuang merged 4 commits into
crypto-org-chain:mainfrom
yihuang:remove-tx-logs

Conversation

@yihuang

@yihuang yihuang commented Sep 22, 2021

Copy link
Copy Markdown
Contributor

Solution:

  • convert tx hash when query logs
  • transaction index in logs start from 0

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Solution:
- convert tx hash when query logs
- transaction index in logs start from 0
@yihuang
yihuang requested a review from a team as a code owner September 22, 2021 04:12
@yihuang
yihuang requested review from devashishdxt and thomas-nguy and removed request for a team September 22, 2021 04:12
@codecov

codecov Bot commented Sep 22, 2021

Copy link
Copy Markdown

Codecov Report

Merging #93 (98bca43) into main (3ea70c5) will increase coverage by 4.64%.
The diff coverage is 41.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   21.51%   26.15%   +4.64%     
==========================================
  Files          27       32       +5     
  Lines        1729     2183     +454     
==========================================
+ Hits          372      571     +199     
- Misses       1324     1575     +251     
- Partials       33       37       +4     
Impacted Files Coverage Δ
app/app.go 3.89% <0.00%> (-0.07%) ⬇️
app/prefix.go 0.00% <0.00%> (ø)
x/cronos/keeper/grpc_query.go 0.00% <0.00%> (ø)
x/cronos/keeper/hooks.go 0.00% <0.00%> (ø)
x/cronos/keeper/msg_server.go 6.45% <0.00%> (ø)
x/cronos/types/query.pb.gw.go 0.00% <0.00%> (ø)
x/cronos/types/tracer.go 0.00% <0.00%> (ø)
x/cronos/keeper/evm.go 57.62% <66.66%> (+5.90%) ⬆️
x/cronos/keeper/evmhooks.go 80.00% <80.00%> (ø)
x/cronos/keeper/evm_log_handlers.go 86.51% <86.51%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdd0e52...98bca43. Read the comment docs.

@thomas-nguy thomas-nguy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
(please fix the lint issue before merging)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants