Skip to content

Problem: eth_call return value is unlimited#907

Merged
yihuang merged 4 commits into
crypto-org-chain:release/v1.0.xfrom
yihuang:return-limit
Mar 6, 2023
Merged

Problem: eth_call return value is unlimited#907
yihuang merged 4 commits into
crypto-org-chain:release/v1.0.xfrom
yihuang:return-limit

Conversation

@yihuang

@yihuang yihuang commented Mar 6, 2023

Copy link
Copy Markdown
Contributor

Solution:

  • apply a configurable limit to return data in json-rpcs

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Solution:
- apply a configurable limit in rpc nodes
@yihuang
yihuang requested a review from a team as a code owner March 6, 2023 00:40
@yihuang
yihuang requested review from JayT106, mmsqe and thomas-nguy and removed request for a team March 6, 2023 00:40
Comment thread go.mod Outdated
@yihuang
yihuang enabled auto-merge (squash) March 6, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants