Skip to content

Problem: no stateful precompiled contract for bank#837

Merged
yihuang merged 2 commits into
crypto-org-chain:mainfrom
mmsqe:precompiled
Sep 18, 2023
Merged

Problem: no stateful precompiled contract for bank#837
yihuang merged 2 commits into
crypto-org-chain:mainfrom
mmsqe:precompiled

Conversation

@mmsqe

@mmsqe mmsqe commented Feb 3, 2023

Copy link
Copy Markdown
Contributor

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

Updates: #1116

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Comment thread x/cronos/keeper/precompiles/ibc.go Fixed
Comment thread x/cronos/keeper/precompiles/ibc.go Fixed
Comment thread x/cronos/keeper/precompiles/ibc.go Fixed
Comment thread x/cronos/keeper/precompiles/ibc.go Fixed
@codecov

codecov Bot commented Sep 15, 2023

Copy link
Copy Markdown

Codecov Report

Merging #837 (36a3882) into main (6935b19) will decrease coverage by 0.07%.
The diff coverage is 29.82%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
- Coverage   34.01%   33.95%   -0.07%     
==========================================
  Files         112      113       +1     
  Lines       11051    11222     +171     
==========================================
+ Hits         3759     3810      +51     
- Misses       6914     7034     +120     
  Partials      378      378              
Files Changed Coverage Δ
x/cronos/keeper/precompiles/bank.go 29.82% <29.82%> (ø)

@mmsqe
mmsqe marked this pull request as ready for review September 15, 2023 02:44
@mmsqe
mmsqe requested a review from a team as a code owner September 15, 2023 02:44
@mmsqe
mmsqe requested review from JayT106 and thomas-nguy and removed request for a team September 15, 2023 02:44
@mmsqe mmsqe changed the title Problem: no stateful precompiled contracts Problem: no stateful precompiled contract for bank Sep 15, 2023

func init() {
addressType, _ := abi.NewType("address", "", nil)
uint256Type, _ := abi.NewType("uint256", "", nil)

Check warning

Code scanning / gosec

Returned error is not propagated up the stack.

Returned error is not propagated up the stack.
)

func init() {
addressType, _ := abi.NewType("address", "", nil)

Check warning

Code scanning / gosec

Returned error is not propagated up the stack.

Returned error is not propagated up the stack.
@yihuang
yihuang self-requested a review September 15, 2023 06:06
Signed-off-by: yihuang <huang@crypto.com>
@yihuang
yihuang enabled auto-merge September 18, 2023 02:36
@yihuang
yihuang added this pull request to the merge queue Sep 18, 2023
Merged via the queue into crypto-org-chain:main with commit 35d10cf Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants