Problem: no stateful precompiled contract for bank#837
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #837 +/- ##
==========================================
- Coverage 34.01% 33.95% -0.07%
==========================================
Files 112 113 +1
Lines 11051 11222 +171
==========================================
+ Hits 3759 3810 +51
- Misses 6914 7034 +120
Partials 378 378
|
mmsqe
marked this pull request as ready for review
September 15, 2023 02:44
mmsqe
requested review from
JayT106 and
thomas-nguy
and removed request for
a team
September 15, 2023 02:44
|
|
||
| func init() { | ||
| addressType, _ := abi.NewType("address", "", nil) | ||
| uint256Type, _ := abi.NewType("uint256", "", nil) |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
| ) | ||
|
|
||
| func init() { | ||
| addressType, _ := abi.NewType("address", "", nil) |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
yihuang
self-requested a review
September 15, 2023 06:06
JayT106
approved these changes
Sep 15, 2023
Signed-off-by: yihuang <huang@crypto.com>
yihuang
approved these changes
Sep 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
Updates: #1116
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)