Problem: unsafe experimental flag is not needed #834
Merged
thomas-nguy merged 9 commits intoFeb 6, 2023
Merged
Conversation
thomas-nguy
requested review from
mmsqe and
yihuang
and removed request for
a team
February 2, 2023 02:43
mmsqe
reviewed
Feb 2, 2023
mmsqe
left a comment
Contributor
There was a problem hiding this comment.
do we still keep package experimental and seems still have experimental in test_helpers
thomas-nguy
force-pushed
the
thomas/remove-unsafe-experimental
branch
from
February 2, 2023 03:02
9023535 to
924dfe3
Compare
thomas-nguy
commented
Feb 2, 2023
thomas-nguy
force-pushed
the
thomas/remove-unsafe-experimental
branch
3 times, most recently
from
February 2, 2023 05:12
053fa53 to
071b154
Compare
Codecov Report
@@ Coverage Diff @@
## main #834 +/- ##
==========================================
+ Coverage 33.89% 34.32% +0.42%
==========================================
Files 30 30
Lines 1599 1579 -20
==========================================
Hits 542 542
+ Misses 1000 980 -20
Partials 57 57
|
calvinaco
reviewed
Feb 2, 2023
calvinaco
left a comment
Contributor
There was a problem hiding this comment.
LGTM, left a comment on the upgrade handler
thomas-nguy
force-pushed
the
thomas/remove-unsafe-experimental
branch
from
February 3, 2023 02:12
071b154 to
a56243a
Compare
calvinaco
reviewed
Feb 3, 2023
thomas-nguy
force-pushed
the
thomas/remove-unsafe-experimental
branch
from
February 4, 2023 08:17
de79f43 to
cbb19e9
Compare
mmsqe
approved these changes
Feb 6, 2023
yihuang
approved these changes
Feb 6, 2023
thomas-nguy
enabled auto-merge (squash)
February 6, 2023 02:22
mmsqe
added a commit
that referenced
this pull request
Apr 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
Remove unsafe experimental flag
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)