Skip to content

Problem: gravity module is not up to date#830

Merged
thomas-nguy merged 4 commits into
crypto-org-chain:mainfrom
thomas-nguy:thomas/upgrade-gravity-bridge
Feb 1, 2023
Merged

Problem: gravity module is not up to date#830
thomas-nguy merged 4 commits into
crypto-org-chain:mainfrom
thomas-nguy:thomas/upgrade-gravity-bridge

Conversation

@thomas-nguy

Copy link
Copy Markdown
Collaborator

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

Include two fixes that patches bugs which could cause the bridge to stop

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@thomas-nguy
thomas-nguy requested a review from a team as a code owner January 31, 2023 02:28
@thomas-nguy
thomas-nguy requested review from devashishdxt and leejw51crypto and removed request for a team January 31, 2023 02:28
@yihuang

yihuang commented Jan 31, 2023

Copy link
Copy Markdown
Contributor

I think we can remove the go-ethereum replacement now:

github.com/ethereum/go-ethereum => github.com/crypto-org-chain/go-ethereum v1.10.19-deepcopy-jumptable

@thomas-nguy

Copy link
Copy Markdown
Collaborator Author

okay I will also make the change

Comment thread go.mod
@thomas-nguy
thomas-nguy requested a review from yihuang January 31, 2023 07:43
@thomas-nguy
thomas-nguy enabled auto-merge (squash) February 1, 2023 01:11
@thomas-nguy
thomas-nguy merged commit ef96d58 into crypto-org-chain:main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants