Skip to content

Problem: recent fixes in dependencies are not used#757

Merged
yihuang merged 2 commits into
crypto-org-chain:release/v1.0.xfrom
yihuang:release/v1.0.x
Nov 2, 2022
Merged

Problem: recent fixes in dependencies are not used#757
yihuang merged 2 commits into
crypto-org-chain:release/v1.0.xfrom
yihuang:release/v1.0.x

Conversation

@yihuang

@yihuang yihuang commented Nov 2, 2022

Copy link
Copy Markdown
Contributor

Solution:

  • cosmos-sdk -> v0.46.4
  • ethermint -> main
  • ibc-go -> v5.0.1
  • add dragonberry ics20 replacement

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

HuangYi
Problem: recent fixes in dependencies are not used
886bf03 
Solution:
- cosmos-sdk -> v0.46.4
- ethermint -> main
- ibc-go -> v5.0.1
- add dragonberry ics20 replacement
@yihuang
yihuang requested a review from a team as a code owner November 2, 2022 01:26
@yihuang
yihuang requested review from devashishdxt and thomas-nguy and removed request for a team November 2, 2022 01:26
tomtau
tomtau approved these changes Nov 2, 2022
View reviewed changes

@tomtau tomtau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the ethermint main ok or better to have a tagged release?

yihuang
yihuang commented Nov 2, 2022
View reviewed changes
Comment thread go.mod
@yihuang

yihuang commented Nov 2, 2022

Copy link
Copy Markdown
Contributor Author

is the ethermint main ok or better to have a tagged release?

changed to crypto-org-chain fork, reverted a breaking change(ethsecp256k1 multisig support), cherry-picked evmos/ethermint#1405.

yihuang
yihuang commented Nov 2, 2022
View reviewed changes
Comment thread go.mod
@yihuang
yihuang requested a review from tomtau November 2, 2022 02:03
@thomas-nguy

thomas-nguy commented Nov 2, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

quick glance, changes look non breaking however better to test before releasing

thomas-nguy
thomas-nguy requested changes Nov 2, 2022
View reviewed changes

@thomas-nguy thomas-nguy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

evmos/ethermint#1388

actually does this change the gas consumed for failed txs?

@yihuang

yihuang commented Nov 2, 2022

Copy link
Copy Markdown
Contributor Author

evmos/ethermint#1388

actually does this change the gas consumed for failed txs?

does it? it seems only reorder some codes to make it efficient, don't change behavior?

thomas-nguy
thomas-nguy approved these changes Nov 2, 2022
View reviewed changes

@thomas-nguy thomas-nguy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok this reordering looks okay because the two other handler put at the top seems stateless.

I was thinking that it could affect the gas_used somehow if the order changes

@yihuang

yihuang commented Nov 2, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Ok this reordering looks okay because the two other handler put at the top seems stateless.

I was thinking that it could affect the gas_used somehow if the order changes

I see, you mean if the tx fail in ante handler, the gas used will be calculated by the sdk operations, those could be changed by this? I need to check it out.

@thomas-nguy

thomas-nguy commented Nov 2, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

also the sdk.error returned could also changes depending of the order?

@yihuang

yihuang commented Nov 2, 2022

Copy link
Copy Markdown
Contributor Author

also the sdk.error returned could also changes depending of the order?

error message is not normally part of the consensus, unless like in the old case, the ibc module record the error message into consensus state, it shouldn't happen now though.

@yihuang
yihuang merged commit 3921c10 into crypto-org-chain:release/v1.0.x Nov 2, 2022
@yihuang
yihuang deleted the release/v1.0.x branch November 2, 2022 08:46
yihuang pushed a commit that referenced this pull request Jan 26, 2023
yihuang @mmsqe @tomtau
Problem: v1.0.x changes are not merged into main (#816)
c6dd8f9 
* Problem: eth_sendTransaction is not tested

* Problem: json-rpc apis fail for legacy blocks after upgrade (#696)

* Problem: json-rpc apis fail for legacy blocks

Solution:
- keep the query handler in cosmos-sdk backward-compatible
- add integration test to check

* update sdk to upstream

* ibc-go to rc2

* Problem: file changes detection in workflow is problematic (backport #703) (#705)

* Problem: file changes detection in workflow is problematic

Solution:
- fix wildcards according the plugin's doc
- reformat python

* fix py-lint

* Problem: after v0.9.0 upgrade eth_call failed on old blocks (backport #713) (#719)

* Problem: after v0.9.0 upgrade eth_call failed on old blocks

Solution:
- make grpc query compatible with old format

* debug

* fix eth_call

* fix gravity upgrade test

* update ethermint to main branch

* update sdk

* Problem: state streamers are not integrated (backport #702) (#721)

Solution:
- integration the basic file streamer

* add integration test

* changelog

* fix build

* fix lint

* fix deliver tx event in cosmos-sdk

* fix integration test

* Update integration_tests/test_streamer.py

Signed-off-by: yihuang <huang@crypto.com>

* update ethermint and fix build

* add a small cli utility into test_streamer.py

* fix integration test

* update sdk to upstream

Signed-off-by: yihuang <huang@crypto.com>

Signed-off-by: yihuang <huang@crypto.com>

* Problem: new iavl indexes migration is slow and not optional (#714) (#720)

* Problem: new iavl indexes migration is slow and not optional

Closes: #712
Solution:
- Integrate the option introduced in cosmos-sdk

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

Signed-off-by: yihuang <huang@crypto.com>

Signed-off-by: yihuang <huang@crypto.com>

* Problem: recent dependencies are not used (backport #729) (#730)

* Problem: recent dependencies are not used (backport #729)

Solution:
- update cosmos-sdk to 0.46.2, ibc-go to v5.0.0, ethermint to recent main branch

Update highlights:
- new flag to disable fast node migration
- fix streaming listeners bug
- fix grpc server panic
- fix index-eth-tx error on empty db

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

Signed-off-by: yihuang <huang@crypto.com>

* Problem: chain state is inconsistent if upgrade migration is interrupted (#748)

* Problem: chain state is inconsistent if upgrade migration is interrupted

Solution:
- update cosmos-sdk with the fix

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* gomod2nix

* skip streamer test

Signed-off-by: yihuang <huang@crypto.com>

* Problem: recent fixes in dependencies are not included (#752)

* Problem: recent fixes in dependencies are not included

Solution:
- update cosmos-sdk and iavl

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* fix build

Signed-off-by: yihuang <huang@crypto.com>

* Problem: binary version is not bump to v1.0.0 (#753)

* Problem: recent fixes in dependencies are not used (#757)

* Problem: recent fixes in dependencies are not used

Solution:
- cosmos-sdk -> v0.46.4
- ethermint -> main
- ibc-go -> v5.0.1
- add dragonberry ics20 replacement

* maintain ethermint fork

* Problem: gas used is not backward compatible (#760)

Solution:
- revert the changes in ethermint

* Problem: evm execute result is non-deterministic with concurrent grpc query (#761)

* Problem: evm execute result is non-deterministic with concurrent grpc query

Solution:
- update dependencies to include the fix

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* Update go.mod

Signed-off-by: yihuang <huang@crypto.com>

Signed-off-by: yihuang <huang@crypto.com>

* Problem: extra_eips is not cleared on production network (#762)

* Problem: extra_eips is not cleared on production network

Closes: #755
Solution:
- add 1.0.0 upgrade plan to clear it

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* Update integration_tests/test_upgrade.py

Signed-off-by: yihuang <huang@crypto.com>

* fix integration test

Signed-off-by: yihuang <huang@crypto.com>

* Problem: no error log when iavl set failure trigger app hash mismatch (#763)

* Problem: no error log when iavl set failure trigger app hash mismatch

Solution:
- log the error in cosmos-sdk

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* PR merged

Signed-off-by: yihuang <huang@crypto.com>

* Problem: different result from eth_getProof comparing with Ethereum (#764)

* Problem: different result from eth_getProof comparing with Ethereum

Solution:
- cherry-pick solution from ethermint, thanks @mmsqe

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

Signed-off-by: yihuang <huang@crypto.com>

* Problem: nix exceeds github rate limit occationally in CI (backport #766) (#768)

Solution:
- configure access-token
- update the action plugins

* Problem: fixes in ibc-go v5.1 are not included (#765)

* Problem: fixes in ibc-go v5.1 are not included

Solution:
- make a breaking change to upgrade to ibc-go `v5.1.0`.
- will do v1.0.0 upgrade on both testnet and mainnet.

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* fix lint

* include cache fix in tendermint

* update sdk

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* make different plan name v1.0.0-testnet3 for testnet3

Signed-off-by: yihuang <huang@crypto.com>
Co-authored-by: mmsqe <mavis@crypto.com>

* Problem: london hardfork number failed validation (#771)

* fix upgrade set parameters

* changelog

* Problem: formal v0.46.5 cosmos-sdk release is not used (#772)

* Problem: formal v0.46.5 cosmos-sdk release is not used

Solution:
- update dependency, should be non-breaking for cronos

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* update to v0.46.6

Signed-off-by: yihuang <huang@crypto.com>

* Problem: final v1.0.0 is not released (#774)

Solution:
- update changelog

* Problem: manual prune cmd is not included (backport #781) (#782)

Solution:
- add to root cmd

* Problem: cosmos-sdk `v0.46.7` is not used (#790)

* Problem: cosmos-sdk `v0.46.7` is not used

Solution:
- update dependency
- `v0.46.7` fix a gov migration issue which affect query votes of old proposals.

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* use sdk streamers config

* fix streamer test

* fix file streamer integration test

* changelog

Signed-off-by: yihuang <huang@crypto.com>

* Problem: discontinued ibc-go version (#802)

* Problem: discontinued ibc-go version

Solution:
- update ibc-go to v5.2.0.
- do another coordinated upgrade on testnet3.

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* Update app/upgrades.go

Signed-off-by: yihuang <huang@crypto.com>

Signed-off-by: yihuang <huang@crypto.com>

* Problem: production rocksdb configuration is not optimal (#813)

* Problem: production rocksdb configuration is not optimal

Solution:
- update related dependencies to allow customize rocksdb options.
- especially using rocksdb v7.
- tune rocksdb options.

* Update Makefile

Signed-off-by: yihuang <huang@crypto.com>

* remove rocksdb from niv

* rocksdb options

* update flake

* fix build

* create_if_missing

* OptimizeLevelStyleCompaction and IncreaseParallelism

* remove SetLevelCompactionDynamicLevelBytes and add BlockCache

* fix integration test

* comments

Signed-off-by: yihuang <huang@crypto.com>

* Problem: prometheus metrics is lost (#814)

* Problem: prometheus metrics is lost

Solution:
- setup correctly in ethermint

* changelog

* release v1.0.3

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* fix changelog

* fix merge

* Update integration_tests/test_upgrade.py

Co-authored-by: mmsqe <tqd0800210105@gmail.com>
Signed-off-by: yihuang <huang@crypto.com>

* fix test

* Update integration_tests/configs/default.jsonnet

Signed-off-by: yihuang <huang@crypto.com>

* fix test_multiple_attestation_processing

* fix changelog

Signed-off-by: yihuang <huang@crypto.com>
Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: mmsqe <tqd0800210105@gmail.com>
Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomas-nguy thomas-nguy thomas-nguy approved these changes
@devashishdxt devashishdxt Awaiting requested review from devashishdxt devashishdxt is a code owner automatically assigned from crypto-org-chain/cronos-dev
+1 more reviewer
@tomtau tomtau tomtau approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yihuang @thomas-nguy @tomtau