Problem: ibc incentivization is not integrated

[yihuang]

Closes: #642
Solution:

• integration ibc fee middleware
• pass exiting integration test
• add ibc incentivized integration test

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

• Have you read the CONTRIBUTING.md?
• Does your PR follow the C4 patch requirements?
• Have you rebased your work on top of the latest master?
• Have you checked your code compiles? (make)
• Have you included tests for any non-trivial functionality?
• Have you checked your code passes the unit tests? (make test)
• Have you checked your code formatting is correct? (go fmt)
• Have you checked your basic code style is fine? (golangci-lint run)
• If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• If your changes affect the client infrastructure, have you run the integration test?
• If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

[lgtm-com]

This pull request introduces 1 alert when merging f229497 into 21d79ac - view on LGTM.com

new alerts:

• 1 for Useless assignment to local variable

[codecov]

Codecov Report

Merging #647 (1744b1e) into main (29c4fec) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #647      +/-   ##
==========================================
- Coverage   32.91%   32.75%   -0.17%     
==========================================
  Files          34       34              
  Lines        1604     1612       +8     
==========================================
  Hits          528      528              
- Misses       1023     1031       +8     
  Partials       53       53              

Impacted Files	Coverage Δ
app/upgrades.go	0.00% <0.00%> (ø)

[devashishdxt]

Integration test seems fine. Just a small comment on app wiring.

[devashishdxt]

Fee middleware is supposed to be backwards compatible. It'll be better if we also write some tests with incentivized=False. I ran into some problems with non-fee enabled channels on chain-main. The issue was faulty app wiring.

[yihuang]

Fee middleware is supposed to be backwards compatible. It'll be better if we also write some tests with incentivized=False. I ran into some problems with non-fee enabled channels on chain-main. The issue was faulty app wiring.

I just parameterized the ibc fixture, to run test cases on both cases.

[yihuang]

/runsim