Skip to content

Problem: json-rpc failed on pruned nodes (backport #550)#567

Merged
yihuang merged 3 commits into
crypto-org-chain:release/v0.7.xfrom
yihuang:test-pruned-rpc-backport
Jul 4, 2022
Merged

Problem: json-rpc failed on pruned nodes (backport #550)#567
yihuang merged 3 commits into
crypto-org-chain:release/v0.7.xfrom
yihuang:test-pruned-rpc-backport

Conversation

@yihuang

@yihuang yihuang commented Jun 30, 2022

Copy link
Copy Markdown
Contributor

Solution:

  • Make basic json-rpc apis works on pruned nodes
  • Test with integration tests

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Comment thread go.mod Outdated
@yihuang
yihuang force-pushed the test-pruned-rpc-backport branch from 036c598 to 79fac1b Compare June 30, 2022 08:03
Solution:
- Make basic json-rpc apis works on pruned nodes
- Test with integration tests

fix test config
@yihuang
yihuang force-pushed the test-pruned-rpc-backport branch from f2ab4fa to 322d16f Compare July 4, 2022 02:32
@yihuang
yihuang marked this pull request as ready for review July 4, 2022 02:32
@yihuang
yihuang requested a review from a team as a code owner July 4, 2022 02:32
@yihuang
yihuang requested review from adu-crypto, leejw51crypto and thomas-nguy and removed request for a team July 4, 2022 02:32

@adu-crypto adu-crypto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in comment, others lgtm

Comment thread x/cronos/rpc/api.go Outdated
@yihuang
yihuang merged commit 0c23f9e into crypto-org-chain:release/v0.7.x Jul 4, 2022
@yihuang
yihuang deleted the test-pruned-rpc-backport branch July 4, 2022 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants