Problem: json-rpc failed on pruned nodes (backport #550)#567
Merged
yihuang merged 3 commits intoJul 4, 2022
Merged
Conversation
yihuang
commented
Jun 30, 2022
yihuang
force-pushed
the
test-pruned-rpc-backport
branch
from
June 30, 2022 08:03
036c598 to
79fac1b
Compare
Solution: - Make basic json-rpc apis works on pruned nodes - Test with integration tests fix test config
yihuang
force-pushed
the
test-pruned-rpc-backport
branch
from
July 4, 2022 02:32
f2ab4fa to
322d16f
Compare
yihuang
marked this pull request as ready for review
July 4, 2022 02:32
yihuang
requested review from
adu-crypto,
leejw51crypto and
thomas-nguy
and removed request for
a team
July 4, 2022 02:32
adu-crypto
approved these changes
Jul 4, 2022
adu-crypto
left a comment
Contributor
There was a problem hiding this comment.
typo in comment, others lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)