Problem: (0.7.x)tendermint could include duplicated tx which mess up the tx indexer#526
Merged
yihuang merged 2 commits intoJul 1, 2022
Conversation
2 tasks
yihuang
commented
May 30, 2022
yihuang
force-pushed
the
fix-duplicated-tx-0-7
branch
from
June 13, 2022 08:14
e589c72 to
2161490
Compare
…indexer ref: crypto-org-chain#523 Solution: - update tendermint dependency to include the fix update tendermint update tendermint and gomod2nix
yihuang
force-pushed
the
fix-duplicated-tx-0-7
branch
from
June 30, 2022 09:31
71d66be to
6dcf911
Compare
yihuang
marked this pull request as ready for review
June 30, 2022 09:31
yihuang
requested review from
calvinaco and
leejw51crypto
and removed request for
a team
June 30, 2022 09:31
yihuang
commented
Jun 30, 2022
thomas-nguy
approved these changes
Jul 1, 2022
thomas-nguy
left a comment
Collaborator
There was a problem hiding this comment.
lgtm,
same comment as for 0.6.x
13 tasks
This was referenced Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #523
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)