Problem: query legacy block failed after upgrade#446
Merged
Conversation
Solution: - fix in ethermint and update the dependency
yihuang
requested review from
devashishdxt and
thomas-nguy
and removed request for
a team
April 29, 2022 03:25
yihuang
marked this pull request as draft
April 29, 2022 03:25
yihuang
commented
Apr 29, 2022
Codecov Report
@@ Coverage Diff @@
## main #446 +/- ##
===========================================
+ Coverage 21.51% 39.40% +17.88%
===========================================
Files 27 31 +4
Lines 1729 1571 -158
===========================================
+ Hits 372 619 +247
+ Misses 1324 906 -418
- Partials 33 46 +13
|
yihuang
marked this pull request as ready for review
April 30, 2022 16:35
yihuang
commented
Apr 30, 2022
| github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1 | ||
|
|
||
| github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.10.0-alpha1-cronos-8.0.20220426081631-a178ce6dba6e | ||
| github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.10.0-alpha1-cronos-8.0.20220430162531-36b9c095b351 |
Contributor
Author
There was a problem hiding this comment.
tomtau
approved these changes
May 3, 2022
tomtau
left a comment
Contributor
There was a problem hiding this comment.
why is there a need for the ethermint fork? can the upstream be used if the PRs are merged?
Contributor
Author
there's still breaking changes are not included for 0.7.0 upgrade, including the ibc-go 0.3, so we'll need to maintain this fork for the 0.7.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)