Problem: dependencies are not up to date#429
Conversation
| replace ( | ||
| // TODO: fix keyring upstream | ||
| github.com/99designs/keyring => github.com/crypto-org-chain/keyring v1.1.6-fixes | ||
| github.com/cosmos/cosmos-sdk => github.com/cosmos/cosmos-sdk v0.45.2-0.20220218085826-7f949c0aa1d6 |
There was a problem hiding this comment.
not sure about if this replace is necessary with 0.42.3? @yihuang
There was a problem hiding this comment.
if there are multiple cosmos-sdk dependencies end up in go.sum, then better keep the replace I think.
68d2674 to
68e686f
Compare
Codecov Report
@@ Coverage Diff @@
## main #429 +/- ##
===========================================
+ Coverage 21.51% 39.40% +17.88%
===========================================
Files 27 31 +4
Lines 1729 1571 -158
===========================================
+ Hits 372 619 +247
+ Misses 1324 906 -418
- Partials 33 46 +13
|
| app.TransferKeeper = ibctransferkeeper.NewKeeper( | ||
| appCodec, keys[ibctransfertypes.StoreKey], app.GetSubspace(ibctransfertypes.ModuleName), | ||
| app.IBCKeeper.ChannelKeeper, &app.IBCKeeper.PortKeeper, | ||
| app.IBCKeeper.ChannelKeeper, app.IBCKeeper.ChannelKeeper, &app.IBCKeeper.PortKeeper, |
There was a problem hiding this comment.
Its because we moved out the ICS4 (middleware) interface from the channel
https://github.com/cosmos/ibc-go/blob/v3.0.0/modules/apps/transfer/keeper/keeper.go#L35
We don't have any ibc middleware yet so we are just using the channel base implementation but probably need to be replaced for this issue
#297
061fc9e to
f9e0aad
Compare
|
there are some conflicts with main branch @adu-crypto |
I see. I will check and resolve confilicts. |
|
Thanks for taking care of the PR @adu-crypto |
9222a58 to
2ec4574
Compare
7982f09 to
c1e3af0
Compare
thomas-nguy
changed the title
|
It seems integration tests finally passing but it takes 72min to run (maybe because we updated rust) is it safe to merge to main or we need to keep it clean for a potential v0.7.1 ? |
Congratulations! |
|
|
||
| // Note: gorocksdb bindings for OptimisticTransactionDB are not merged upstream, so we use a fork | ||
| // See https://github.com/tecbot/gorocksdb/pull/216 | ||
| github.com/tecbot/gorocksdb => github.com/cosmos/gorocksdb v1.1.1 |
There was a problem hiding this comment.
it seems cosmos-sdk don't need this replace anymore, I think it's ok to remove this.
yihuang
left a comment
yihuang
left a comment
There was a problem hiding this comment.
the gorocksdb replace looks redundant now, looks good other than that
|
adcd373#diff-6a5567abee992c210e5cb96abc84014e04fc10cc42eb0e9b27c342cee58ec002L667 you need to add this part manually due to a gomod2nix issue I think 😂 |
fix lint and add changelog fix unit test update gomod2nix upgrade gravity fix gomod2nix fix integration tests fix gomod2nix update ethermint to latest commit to support evm simulation update ethermint cosmos sdk to 0.45.4 update gomod2nix from go.mod Update gomod2nix.toml Update CHANGELOG.md Co-authored-by: yihuang <huang@crypto.com> remove v0.7.0 upgradehandler use base_fee in feemarket params to replace initial_base_fee remove v0.7.0 related upgrade handler update changelog add chaincfg module manually skip test_cosmovisor_upgrade fix lint error use string for feemarket base_fee value update gravity bridge to commit a016e2b04866 use relPath update gravity-bridge for integration tests fix test gravity remove gorockdb replace Update CHANGELOG.md manually add chaincfg config to avoid build failure
a7ea2ed to
bf7a191
Compare
4 participants
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
Update ethermint to latest main (v0.6.1-0.20220416173130-bc4b018b60b1)
Use ibc-go v3.0.0
Update cosmos sdk to v0.45.3
Upgrate gravity
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)