Feature: support logs for evm hooks#418
Merged
thomas-nguy merged 5 commits intoMay 23, 2022
Merged
Conversation
thomas-nguy
requested review from
leejw51crypto and
yihuang
and removed request for
a team
April 7, 2022 03:22
thomas-nguy
force-pushed
the
thomas/gravity-bridge-cancel
branch
from
April 7, 2022 03:24
a02021b to
88f20c2
Compare
Codecov Report
@@ Coverage Diff @@
## main #418 +/- ##
==========================================
+ Coverage 39.40% 39.63% +0.23%
==========================================
Files 31 31
Lines 1571 1607 +36
==========================================
+ Hits 619 637 +18
- Misses 906 924 +18
Partials 46 46
|
thomas-nguy
force-pushed
the
thomas/gravity-bridge-cancel
branch
5 times, most recently
from
April 8, 2022 05:02
2eb94a2 to
c71a354
Compare
yihuang
reviewed
Apr 8, 2022
yihuang
left a comment
yihuang
left a comment
Contributor
There was a problem hiding this comment.
Changes looks good, should we do some test on it?
Collaborator
Author
|
for the integration tests, we need the latest ethermint main. Is it safe to upgrade ethermint at this moment? or still need to work on a forked version for the final release? |
Contributor
time to create the I just created, you can make breaking changes to main branch now. |
thomas-nguy
changed the title
linfeng-crypto
approved these changes
May 10, 2022
thomas-nguy
force-pushed
the
thomas/gravity-bridge-cancel
branch
from
May 18, 2022 13:00
c71a354 to
a81e1a5
Compare
Collaborator
Author
|
blocked by evmos/ethermint#1088 |
thomas-nguy
changed the title
thomas-nguy
commented
May 20, 2022
| // TODO: fix keyring upstream | ||
| github.com/99designs/keyring => github.com/crypto-org-chain/keyring v1.1.6-fixes | ||
| github.com/cosmos/cosmos-sdk => github.com/cosmos/cosmos-sdk v0.45.4 | ||
| github.com/cosmos/cosmos-sdk => github.com/crypto-org-chain/cosmos-sdk v0.44.4-0.20220518050709-bd4ca739c699 |
Collaborator
Author
There was a problem hiding this comment.
needed for ethermint main dependency
thomas-nguy
commented
May 20, 2022
| # __CronosSendToEthereum | ||
| # __CronosSendToEthereumResponse | ||
| assert len(txreceipt.logs) == 3 | ||
| assert get_id_from_receipt(txreceipt) == \ |
thomas-nguy
force-pushed
the
thomas/gravity-bridge-cancel
branch
from
May 20, 2022 06:05
7732249 to
10a4928
Compare
thomas-nguy
force-pushed
the
thomas/gravity-bridge-cancel
branch
from
May 20, 2022 06:08
10a4928 to
55a5b02
Compare
thomas-nguy
commented
May 23, 2022
| github.com/tendermint/tendermint v0.34.20-0.20220517115723-e6f071164839 | ||
| github.com/tendermint/tm-db v0.6.7 | ||
| github.com/tharsis/ethermint v0.6.1-0.20220503175102-93d15db4d086 | ||
| github.com/tharsis/ethermint v0.6.1-0.20220519101126-9edc87d1147f |
Collaborator
Author
There was a problem hiding this comment.
update ethermint to latest to include evmos/ethermint@9edc87d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)