Problem: recent bug fixes are not included#340
Merged
Conversation
yihuang
requested review from
JayT106 and
calvinaco
and removed request for
a team
February 14, 2022 09:01
yihuang
commented
Feb 14, 2022
yihuang
commented
Feb 14, 2022
Codecov Report
@@ Coverage Diff @@
## main #340 +/- ##
===========================================
+ Coverage 21.51% 41.06% +19.54%
===========================================
Files 27 30 +3
Lines 1729 1505 -224
===========================================
+ Hits 372 618 +246
+ Misses 1324 841 -483
- Partials 33 46 +13
|
yihuang
commented
Feb 14, 2022
| github.com/99designs/keyring => github.com/crypto-org-chain/keyring v1.1.6-fixes | ||
| github.com/cosmos/cosmos-sdk => github.com/cosmos/cosmos-sdk v0.45.1 | ||
| // release/v0.45.x branch, TODO use tag when released | ||
| github.com/cosmos/cosmos-sdk => github.com/cosmos/cosmos-sdk v0.45.2-0.20220209090836-4161d2b6022a |
Contributor
Author
There was a problem hiding this comment.
yihuang
marked this pull request as draft
February 14, 2022 09:11
Solution: - update ethermint/cosmos-sdk dependencies - prepare a breaking upgrade on testnet changelog Apply suggestions from code review
yihuang
force-pushed
the
testnet-hotfix
branch
from
February 14, 2022 09:41
a218a04 to
60090c5
Compare
yihuang
marked this pull request as ready for review
February 14, 2022 09:43
yihuang
force-pushed
the
testnet-hotfix
branch
from
February 14, 2022 10:04
fa79201 to
3e64b96
Compare
JayT106
reviewed
Feb 14, 2022
yihuang
commented
Feb 15, 2022
added 2 commits
February 15, 2022 11:13
added 3 commits
February 15, 2022 15:33
should use genesis binary to create initial genesis file.
yihuang
force-pushed
the
testnet-hotfix
branch
from
February 15, 2022 10:29
0183316 to
7058de4
Compare
yihuang
commented
Feb 15, 2022
| github.com/tecbot/gorocksdb => github.com/cosmos/gorocksdb v1.1.1 | ||
|
|
||
| github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.10.0-alpha1-cronos-4 | ||
| github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.10.0-alpha1-cronos-6 |
Contributor
Author
There was a problem hiding this comment.
added 2 commits
February 15, 2022 19:08
thomas-nguy
reviewed
Feb 16, 2022
| return app.mm.RunMigrations(ctx, app.configurator, fromVM) | ||
| }) | ||
| // this upgrade is for breaking bug fixes on testnet | ||
| plan0_7_0HotfixTestnet := "v0.7.0-hotfix-testnet" |
Collaborator
There was a problem hiding this comment.
since we are planning to do a new binary release, should be increase the minor version?
Contributor
Author
There was a problem hiding this comment.
currently, it's still 0.7.0-rcX
Collaborator
There was a problem hiding this comment.
maybe change the name of the plan to "v0.7.0-rc2" ?
Because if we do another upgrade for testnet hotfix after this one, the naming will become really confusing
thomas-nguy
approved these changes
Feb 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)