Skip to content

Problem: batchTxExecuted use wrong contract address in gravity bridge module#323

Merged
thomas-nguy merged 1 commit into
crypto-org-chain:mainfrom
thomas-nguy:thomas/update-gravity
Feb 2, 2022
Merged

Problem: batchTxExecuted use wrong contract address in gravity bridge module#323
thomas-nguy merged 1 commit into
crypto-org-chain:mainfrom
thomas-nguy:thomas/update-gravity

Conversation

@thomas-nguy

Copy link
Copy Markdown
Collaborator

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

Solution: Bump gravity module version to latest main (d52551b27f65)

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@thomas-nguy
thomas-nguy requested a review from a team as a code owner January 31, 2022 01:31
@thomas-nguy
thomas-nguy requested review from JayT106 and yihuang and removed request for a team January 31, 2022 01:31
@thomas-nguy thomas-nguy changed the title Problem: Fix batchTxExecuted in gravity bridge module Problem: batchTxExecuted use wrong contract address in gravity bridge module Jan 31, 2022
@codecov

codecov Bot commented Jan 31, 2022

Copy link
Copy Markdown

Codecov Report

Merging #323 (62f1dcd) into main (3ea70c5) will increase coverage by 19.54%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #323       +/-   ##
===========================================
+ Coverage   21.51%   41.06%   +19.54%     
===========================================
  Files          27       30        +3     
  Lines        1729     1505      -224     
===========================================
+ Hits          372      618      +246     
+ Misses       1324      841      -483     
- Partials       33       46       +13     
Impacted Files Coverage Δ
x/cronos/genesis.go 61.53% <ø> (-38.47%) ⬇️
x/cronos/handler.go 100.00% <ø> (ø)
x/cronos/keeper/evm.go 58.00% <ø> (+6.27%) ⬆️
x/cronos/keeper/evm_hooks.go 80.00% <ø> (ø)
x/cronos/keeper/evm_log_handlers.go 83.50% <ø> (ø)
x/cronos/keeper/gravity_hooks.go 0.00% <ø> (ø)
x/cronos/keeper/grpc_query.go 0.00% <ø> (ø)
x/cronos/keeper/ibc.go 83.20% <ø> (+5.01%) ⬆️
x/cronos/keeper/ibc_hooks.go 50.00% <ø> (-8.83%) ⬇️
x/cronos/keeper/keeper.go 64.89% <ø> (-29.45%) ⬇️
... and 28 more

@thomas-nguy
thomas-nguy force-pushed the thomas/update-gravity branch from 32af1f1 to 863e754 Compare January 31, 2022 01:38
Comment thread go.sum Outdated
Comment on lines 841 to 842
github.com/peggyjv/gravity-bridge/module v0.3.4 h1:a3Nfcw8dM97sv5kOoF97NvnigB2rw1+dj84Bhuk94vg=
github.com/peggyjv/gravity-bridge/module v0.3.4/go.mod h1:IFm0SoZGHzA8c6NH3YyRSl2sGT7qdxY+DimCrP2+J+4=

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is v0.3.4 still depended on by anything?

@thomas-nguy
thomas-nguy force-pushed the thomas/update-gravity branch 2 times, most recently from 6d60154 to 73aff20 Compare January 31, 2022 02:01
@thomas-nguy thomas-nguy changed the title Problem: batchTxExecuted use wrong contract address in gravity bridge module [Draft] Problem: batchTxExecuted use wrong contract address in gravity bridge module Jan 31, 2022
@thomas-nguy

Copy link
Copy Markdown
Collaborator Author

I will keep this PR open for the time being til sommelier do an official release

@thomas-nguy
thomas-nguy force-pushed the thomas/update-gravity branch from 73aff20 to 617dc25 Compare February 1, 2022 01:47
@thomas-nguy thomas-nguy changed the title [Draft] Problem: batchTxExecuted use wrong contract address in gravity bridge module Problem: batchTxExecuted use wrong contract address in gravity bridge module Feb 1, 2022
@thomas-nguy
thomas-nguy force-pushed the thomas/update-gravity branch from 617dc25 to 62f1dcd Compare February 1, 2022 01:54
@thomas-nguy
thomas-nguy merged commit d3d3ff2 into crypto-org-chain:main Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants