Skip to content

Conversation

@thomas-nguy
Copy link
Collaborator

@thomas-nguy thomas-nguy commented Jan 13, 2026

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • Documentation

    • Added a v1.7.0 changelog entry listing upcoming improvements.
  • Chores

    • Updated a third‑party dependency mapping to a newer resolved version and checksum.
  • Tests

    • Added a pre-build step to prepare integration "upgrade" (and full) test runs before pytest.
  • Breaking Changes

    • EVM-related call return types were changed; callers must adapt to the new response shape.

✏️ Tip: You can customize this high-level summary in your review settings.

@thomas-nguy thomas-nguy requested a review from a team as a code owner January 13, 2026 09:07
@thomas-nguy thomas-nguy requested review from JayT106 and songgaoye and removed request for a team January 13, 2026 09:07
@github-actions
Copy link

github-actions bot commented Jan 13, 2026

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

Unknown release type "release" found in pull request title "release: v1.7.0". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 13, 2026

📝 Walkthrough

Walkthrough

Updates changelog (adds UNRELEASED v1.7.0 entry), bumps github.com/evmos/ethermint replacement/version and checksum, adds a pre-build nix-build step for upgrade integration tests, and changes EVM-related method return types from *evmtypes.MsgEthereumTxResponse to *evmtypes.EVMResult.

Changes

Cohort / File(s) Summary
Changelog
CHANGELOG.md
Added an UNRELEASED entry (Jan 13, 2026) with a new v1.7.0 Improvements subsection (additive only).
Go module metadata
go.mod, gomod2nix.toml
Bumped github.com/evmos/ethermint replacement from a commit-style v0.22.x ref to v0.23.0 and updated the associated checksum.
CI / Test script
scripts/run-integration-tests
Added pre-build step: run nix-build integration_tests/configs/upgrade-test-package.nix when TESTS_TO_RUN is upgrade or all before invoking pytest.
EVM API changes
x/cronos/keeper/evm.go, x/cronos/types/interfaces.go
Adjusted signatures to return *evmtypes.EVMResult instead of *evmtypes.MsgEthereumTxResponse (CallEVM, ApplyMessage).

Sequence Diagram(s)

(omitted — changes do not introduce multi-component control flow warranting a sequence diagram)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

nix

Suggested reviewers

  • JayT106
  • thomas-nguy
  • XinyuCRO

Poem

🐇 A hop, a tweak, a tiny cheer,
New versions logged and checksums near.
Builds prepped softly for upgrades to run,
EVM replies changed — type swap done.
Rabbit twitches whiskers — merge time’s fun.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'release: v1.7.0' is clear, concise, and directly reflects the main objective of preparing a v1.7.0 release, as confirmed by the CHANGELOG updates, dependency version bumps, and build script modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.51%. Comparing base (a3c2f70) to head (9c947d4).
⚠️ Report is 137 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1953      +/-   ##
==========================================
+ Coverage   16.87%   25.51%   +8.63%     
==========================================
  Files          72       78       +6     
  Lines        6163     5150    -1013     
==========================================
+ Hits         1040     1314     +274     
+ Misses       5000     3673    -1327     
- Partials      123      163      +40     
Files with missing lines Coverage Δ
x/cronos/keeper/evm.go 60.55% <100.00%> (+60.55%) ⬆️

... and 72 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added the build label Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants