release: v1.5.0 #1864
release: v1.5.0 #1864
Conversation
thomas-nguy
requested review from
XinyuCRO and
randy-cro
and removed request for
a team
WalkthroughAdded an UNRELEASED v1.5.0 entry to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Pre-merge checks (3 passed)✅ Passed checks (3 passed)
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
CHANGELOG.md (1)
24-24: Fix incorrect PR URLLabel is “#1851” but URL ends with “/pull/1850”. Likely a copy-paste error.
Apply this correction:
-* [#1851](https://github.com/crypto-org-chain/cronos/pull/1850) Add default value of CancunTime and PragueTime in chain config. +* [#1851](https://github.com/crypto-org-chain/cronos/pull/1851) Add default value of CancunTime and PragueTime in chain config.
🧹 Nitpick comments (3)
CHANGELOG.md (3)
5-5: Silence markdownlint MD036 for date linemarkdownlint flags the italicized date as “emphasis used instead of a heading.” This formatting is consistent with the rest of the changelog. Either disable the rule for this line or adjust tooling.
Apply this local, non-invasive fix:
+# markdownlint-disable-next-line MD036 *Sep 4, 2025*
14-14: Grammar fix in state machine breaking note“Tense/wording reads off.”
-* [#1846](https://github.com/crypto-org-chain/cronos/pull/1846) Enforce app creator returning application implement AppWithPendingTxStream during compilation phase +* [#1846](https://github.com/crypto-org-chain/cronos/pull/1846) Enforce the app creator to return an application that implements AppWithPendingTxStream during the compilation phase.
18-22: Minor copy edits for consistency and capitalizationAlign with common casing used elsewhere in the changelog.
-* [#1841](https://github.com/crypto-org-chain/cronos/pull/1841) Ci: use `golangci-lint run --fix`. +* [#1841](https://github.com/crypto-org-chain/cronos/pull/1841) CI: use `golangci-lint run --fix`. -* [#1824](https://github.com/crypto-org-chain/cronos/pull/1824) Rework on github actions. +* [#1824](https://github.com/crypto-org-chain/cronos/pull/1824) Rework GitHub Actions. -* [#1826](https://github.com/crypto-org-chain/cronos/pull/1826) Update linter and tidy up code. +* [#1826](https://github.com/crypto-org-chain/cronos/pull/1826) Update linters and tidy up code.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md
5-5: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
CHANGELOG.md (1)
7-8: v1.5.0 section header LGTMStructure matches existing conventions (date line preceding version header).
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
CHANGELOG.md (1)
25-25: Another PR number/URL mismatch.Label #1851 links to /pull/1850. Align them.
Pick the correct one:
- * [#1851](https://github.com/crypto-org-chain/cronos/pull/1850) Add default value of CancunTime and PragueTime in chain config. + * [#1850](https://github.com/crypto-org-chain/cronos/pull/1850) Add default value of CancunTime and PragueTime in chain config.or
- * [#1851](https://github.com/crypto-org-chain/cronos/pull/1850) Add default value of CancunTime and PragueTime in chain config. + * [#1851](https://github.com/crypto-org-chain/cronos/pull/1851) Add default value of CancunTime and PragueTime in chain config.
♻️ Duplicate comments (1)
CHANGELOG.md (1)
11-11: Fix PR number/URL mismatch (label vs link).Label shows #1731 but URL points to /pull/1804. Make them consistent.
Apply one of the following, whichever is correct:
- * [#1731](https://github.com/crypto-org-chain/cronos/pull/1804) Upgrade to ibc-go v10.1.1 + * [#1804](https://github.com/crypto-org-chain/cronos/pull/1804) Upgrade to ibc-go v10.1.1or
- * [#1731](https://github.com/crypto-org-chain/cronos/pull/1804) Upgrade to ibc-go v10.1.1 + * [#1731](https://github.com/crypto-org-chain/cronos/pull/1731) Upgrade to ibc-go v10.1.1
🧹 Nitpick comments (5)
CHANGELOG.md (5)
5-8: Clarify release state: UNRELEASED header with a concrete date is confusing.Either keep UNRELEASED without a date until tagging, or finalize the section (drop UNRELEASED and keep the date).
Options:
- Pre-release style:
-## UNRELEASED - -*Sep 4, 2025* - -## v1.5.0 +## UNRELEASED + +<!-- Placeholder for future changes --> + +## v1.5.0 +*Sep 4, 2025*
- Post-release style (once tagged):
-## UNRELEASED - -*Sep 4, 2025* - -## v1.5.0 +## v1.5.0 +*Sep 4, 2025* + +## UNRELEASED +<!-- Placeholder for future changes -->
13-13: Trim trailing whitespace.-* [#1846](https://github.com/crypto-org-chain/cronos/pull/1846) Enforce app creator returning application implement AppWithPendingTxStream during compilation phase +* [#1846](https://github.com/crypto-org-chain/cronos/pull/1846) Enforce app creator returning application implement AppWithPendingTxStream during compilation phase
28-28: Normalize heading capitalization (“Bug fixes” → “Bug Fixes”).Matches prior sections (e.g., Lines 44, 53, 66). Consistency helps scanning.
-### Bug fixes +### Bug Fixes
18-18: Capitalize “CI” acronym.-* [#1841](https://github.com/crypto-org-chain/cronos/pull/1841) Ci: use `golangci-lint run --fix`. +* [#1841](https://github.com/crypto-org-chain/cronos/pull/1841) CI: use `golangci-lint run --fix`.
5-5: markdownlint MD036 (emphasis used as heading).House style uses italicized dates throughout. Either disable MD036 for date lines or convert dates to subheadings project-wide.
Minimal suppression (preferred to preserve style):
- *Sep 4, 2025* +<!-- markdownlint-disable-next-line MD036 --> +*Sep 4, 2025*
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md
5-5: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: integration_tests (ica)
- GitHub Check: integration_tests (slow)
- GitHub Check: integration_tests (gov)
- GitHub Check: build (macos-latest)
- GitHub Check: integration_tests (unmarked)
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: semgrep-cloud-platform/scan
b952195
2 participants
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit