Problem: Cronos params name has an unnecessary Key prefix

[calvinaco]

Solution: (Fix #184) Remove the Key from params name

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

• Have you read the CONTRIBUTING.md?
• Does your PR follow the C4 patch requirements?
• Have you rebased your work on top of the latest master?
• Have you checked your code compiles? (make)
• Have you included tests for any non-trivial functionality?
• Have you checked your code passes the unit tests? (make test)
• Have you checked your code formatting is correct? (go fmt)
• Have you checked your basic code style is fine? (golangci-lint run)
• If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• If your changes affect the client infrastructure, have you run the integration test?
• If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

[codecov]

Codecov Report

Merging #185 (dd7651d) into main (3ea70c5) will increase coverage by 5.11%.
The diff coverage is 54.06%.

@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
+ Coverage   21.51%   26.63%   +5.11%     
==========================================
  Files          27       33       +6     
  Lines        1729     2328     +599     
==========================================
+ Hits          372      620     +248     
- Misses       1324     1662     +338     
- Partials       33       46      +13     

Impacted Files	Coverage Δ
app/prefix.go	0.00% <0.00%> (ø)
app/test_helpers.go	0.00% <0.00%> (ø)
x/cronos/keeper/grpc_query.go	0.00% <0.00%> (ø)
x/cronos/keeper/msg_server.go	5.00% <0.00%> (-1.46%)	⬇️
x/cronos/module.go	59.64% <0.00%> (-2.17%)	⬇️
x/cronos/types/codec.go	0.00% <0.00%> (ø)
x/cronos/types/events.go	0.00% <ø> (ø)
x/cronos/types/messages.go	20.22% <ø> (+20.22%)	⬆️
x/cronos/types/params.go	57.35% <ø> (+3.78%)	⬆️
x/cronos/types/proposal.go	11.11% <ø> (ø)
... and 19 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4826ffc...dd7651d. Read the comment docs.

[thomas-nguy]

lgtm

[tomtau]

maybe also add a test with the param name changes when that bug is captured?

[calvinaco]

maybe also add a test with the param name changes when that bug is captured?

Sure, let me take a look on how to do it.

[tomtau]

maybe also add a test with the param name changes when that bug is captured?

it can be ignored -- I thought the "Key" prefix was causing some issues in paramchange proposal, so nothing to test here