Problem: Version CLI command doesn't output any text#178
Merged
Conversation
Closes: crypto-org-chain#177 Solution: - add ldflags to Makefile, goreleaser version is good
yihuang
requested review from
calvinaco and
devashishdxt
and removed request for
a team
October 15, 2021 01:09
Codecov Report
@@ Coverage Diff @@
## main #178 +/- ##
==========================================
+ Coverage 21.51% 26.63% +5.11%
==========================================
Files 27 33 +6
Lines 1729 2328 +599
==========================================
+ Hits 372 620 +248
- Misses 1324 1662 +338
- Partials 33 46 +13
Continue to review full report at Codecov.
|
thomas-nguy
approved these changes
Oct 15, 2021
thomas-nguy
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
This seems to work for release binaries
Contributor
Author
yeah, goreleaser version has these flags already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #177
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)