Bump ethermint v0.7.1#169
Conversation
c9e695a to
a4f2a75
Compare
Codecov Report
@@ Coverage Diff @@
## main #169 +/- ##
==========================================
+ Coverage 21.51% 26.42% +4.90%
==========================================
Files 27 34 +7
Lines 1729 2426 +697
==========================================
+ Hits 372 641 +269
- Misses 1324 1737 +413
- Partials 33 48 +15
Continue to review full report at Codecov.
|
|
still having issue to update gomod2nix with my vpn |
One idea is we can change the workflow to upload the artifact when dirty, similar to this: https://github.com/crypto-org-chain/cronos/blob/main/.github/workflows/test.yml#L28. So you can download the generated file and commit again. |
|
|
||
| // FIXME: https://github.com/crypto-org-chain/ethermint/tree/cronos2 | ||
| replace github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.4.2-0.20211004101819-7b5449f36cc8 | ||
| replace github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.7.1-patched |
There was a problem hiding this comment.
it seems the only change is https://github.com/crypto-org-chain/ethermint/commits/thomas/v0.7.1-patched the go-ethereum -- I think that isn't needed, it's enough just to have the line to replace go-ethereum here (it'd use it in all dependencies, i.e. it's fine to use github.com/tharsis/ethermint without replacing ethermint)
a4f2a75 to
eeaf188
Compare
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
Bump ethermint version
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)