Problem: authz module has security vulnerability#167
Conversation
Codecov Report
@@ Coverage Diff @@
## main #167 +/- ##
==========================================
+ Coverage 21.51% 26.46% +4.95%
==========================================
Files 27 34 +7
Lines 1729 2422 +693
==========================================
+ Hits 372 641 +269
- Misses 1324 1733 +409
- Partials 33 48 +15
Continue to review full report at Codecov.
|
tomtau
left a comment
There was a problem hiding this comment.
should be ok to disable -- I was just checking for some inter-module dependencies. so far only saw this in bank: https://github.com/cosmos/cosmos-sdk/blob/59810f3286420ab73452b635aebeffac9146e355/x/bank/types/codec.go#L25
but hopefully that's harmless
Changed to bump cosmos-sdk to 0.44.2 instead. |
| replace github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.4.2-0.20211004101819-7b5449f36cc8 | ||
|
|
||
| // TODO: remove when ibc-go and ethermint upgrades cosmos-sdk | ||
| replace github.com/cosmos/cosmos-sdk => github.com/cosmos/cosmos-sdk v0.44.2 |
There was a problem hiding this comment.
would that replace the cosmos-sdk dependency in ibc-go and ethermint without any side effect?
There was a problem hiding this comment.
Hard to say about side-effect, but I think it's safer than using different versions at the same time.
Solution: - update cosmos-sdk to 0.44.2 use replace
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)