Problem: v1.4.0-rc0 is not released #1578
Conversation
yihuang
requested review from
mmsqe and
thomas-nguy
and removed request for
a team
|
Warning Rate limit exceeded@mmsqe has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 27 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe pull request updates the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (2)
go.mod (2)
12-12: Review release notes forcosmossdk.io/logversion update.The minor version update for
cosmossdk.io/logfromv1.3.1tov1.4.0looks good. However, please review the release notes to understand the new features and changes introduced in this version and ensure they are needed in the project.
19-19: Review release notes forcosmossdk.io/x/upgradeversion update.The minor version update for
cosmossdk.io/x/upgradefromv0.1.1tov0.1.4looks good. However, please review the release notes to understand the new features and changes introduced in this version and ensure they are needed in the project.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
Files selected for processing (2)
- go.mod (7 hunks)
- gomod2nix.toml (10 hunks)
Additional comments not posted (32)
go.mod (13)
9-9: Verify compatibility of updatedcosmossdk.io/client/v2version.The version update from
v2.0.0-beta.2tov2.0.0-beta.3looks good. However, please ensure that the updated version is compatible with the other dependencies in the project, especiallycosmossdk.io/coreandgithub.zerozr99.workers.dev/cosmos/cosmos-sdk.
10-10: LGTM!The patch version update for
cosmossdk.io/corefromv0.11.0tov0.11.1looks good. It should include bug fixes and performance improvements without introducing any breaking changes.
16-16: LGTM!The patch version update for
cosmossdk.io/tools/confixfromv0.1.1tov0.1.2looks good. It should include bug fixes and performance improvements without introducing any breaking changes.
17-17: LGTM!The patch version update for
cosmossdk.io/x/evidencefromv0.1.0tov0.1.1looks good. It should include bug fixes and performance improvements without introducing any breaking changes.
18-18: LGTM!The patch version update for
cosmossdk.io/x/feegrantfromv0.1.0tov0.1.1looks good. It should include bug fixes and performance improvements without introducing any breaking changes.
24-24: LGTM!The patch version update for
github.com/cosmos/cosmos-sdkfromv0.50.7tov0.50.9looks good. It should include bug fixes and performance improvements without introducing any breaking changes.
26-26: Review release notes and changelog forgithub.zerozr99.workers.dev/cosmos/ibc-go/modules/apps/callbacksversion update.The pre-release version update for
github.com/cosmos/ibc-go/modules/apps/callbacksfromv0.0.0-20240410121711-d89cb0895b1etov0.0.0-20240830091851-3077be12f11elooks good. However, please review the release notes and changelog to understand the changes introduced in this version and ensure they are compatible with the project, especially since the comment suggests that this version is associated with thev8.5.0release ofibc-go.
27-27: LGTM!The patch version update for
github.com/cosmos/ibc-go/modules/capabilityfromv1.0.0tov1.0.1looks good. It should include bug fixes and performance improvements without introducing any breaking changes.
28-28: Review release notes and changelog forgithub.zerozr99.workers.dev/cosmos/ibc-go/v8version update.The minor version update for
github.com/cosmos/ibc-go/v8fromv8.3.2tov8.5.0looks good. However, please review the release notes and changelog to understand the new features and changes introduced in this version and ensure they are compatible with the project.
46-46: Skipping review ofgoogle.golang.org/genproto/googleapis/apiversion update.The version update for
google.golang.org/genproto/googleapis/apiappears to be a duplicate or unnecessary change as the version number has not changed. Skipping the review of this dependency update.
47-47: Review release notes and changelog forgoogle.golang.org/grpcversion update.The minor version update for
google.golang.org/grpcfromv1.63.2tov1.65.0looks good. However, please review the release notes and changelog to understand the new features and changes introduced in this version and ensure they are compatible with the project.
53-53: Review release notes and changelog forcloud.google.com/goversion update.The minor version update for
cloud.google.com/gofromv0.112.1tov0.115.0looks good. However, please review the release notes and changelog to understand the new features and changes introduced in this version and ensure they are compatible with the project.
57-57: LGTM!The patch version update for
cloud.google.com/go/iamfromv1.1.6tov1.1.9looks good. It should include bug fixes and performance improvements without introducing any breaking changes.gomod2nix.toml (19)
5-6: LGTM!Updating to the latest version of
cloud.google.com/gomodule. Looks good.
8-9: LGTM!Updating to the latest version of
cloud.google.com/go/authmodule. Looks good.
11-12: LGTM!Updating to the latest version of
cloud.google.com/go/auth/oauth2adaptmodule. Looks good.
17-18: LGTM!Updating to the latest version of
cloud.google.com/go/iammodule. Looks good.
20-21: LGTM!Updating to the latest version of
cloud.google.com/go/storagemodule. Looks good.
33-34: LGTM!Updating to the latest version of
cosmossdk.io/coremodule. Looks good.
36-37: LGTM!The
cosmossdk.io/depinjectmodule is transitioning from an alpha versionv1.0.0-alpha.4to a stable versionv1.0.0, which is a significant milestone. Looks good.
42-43: LGTM!Updating to the latest version of
cosmossdk.io/logmodule. Looks good.
55-56: LGTM!Updating to the latest version of
cosmossdk.io/tools/confixmodule. Looks good.
58-59: LGTM!Updating to the latest version of
cosmossdk.io/x/evidencemodule. Looks good.
61-62: LGTM!Updating to the latest version of
cosmossdk.io/x/feegrantmodule. Looks good.
68-69: LGTM!Updating to the latest version of
cosmossdk.io/x/upgrademodule. Looks good.
192-193: LGTM!Updating to the latest version of
github.com/cosmos/ibc-go/modules/apps/callbacksmodule. Looks good.
195-196: LGTM!Updating to the latest version of
github.com/cosmos/ibc-go/modules/capabilitymodule. Looks good.
198-199: LGTM!Updating to the latest version of
github.com/cosmos/ibc-go/v8module. Looks good.
201-202: LGTM!Updating to the latest version of
github.com/cosmos/ics23/gomodule. Looks good.
323-324: LGTM!Updating to the latest version of
github.com/golang/glogmodule. Looks good.
356-357: LGTM!Updating to the latest version of
github.com/googleapis/gax-go/v2module. Looks good.
539-540: LGTM!Updating to the latest version of
github.com/rs/zerologmodule. Looks good.
[
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1578 +/- ##
===========================================
+ Coverage 15.24% 36.12% +20.88%
===========================================
Files 67 97 +30
Lines 4874 7725 +2851
===========================================
+ Hits 743 2791 +2048
- Misses 4037 4585 +548
- Partials 94 349 +255 |
2 participants
main features:
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit
New Features
Chores