Problem: external token mapping not manageable directly#128
Merged
Conversation
yihuang
requested review from
calvinaco and
devashishdxt
and removed request for
a team
September 30, 2021 04:24
Codecov Report
@@ Coverage Diff @@
## main #128 +/- ##
==========================================
+ Coverage 21.51% 25.89% +4.38%
==========================================
Files 27 34 +7
Lines 1729 2367 +638
==========================================
+ Hits 372 613 +241
- Misses 1324 1709 +385
- Partials 33 45 +12
Continue to review full report at Codecov.
|
yihuang
commented
Sep 30, 2021
Closes: crypto-org-chain#119 Solution: - add native message to update token mapping unit tests Update x/cronos/keeper/msg_server.go fix lint fix msgs
yihuang
force-pushed
the
token-mapping
branch
from
September 30, 2021 06:01
db29c6d to
eb25147
Compare
added 2 commits
September 30, 2021 14:03
thomas-nguy
reviewed
Oct 7, 2021
| | ----- | ---- | ----- | ----------- | | ||
| | `ibc_cro_denom` | [string](#string) | | | | ||
| | `ibc_timeout` | [uint64](#uint64) | | | | ||
| | `cronos_admin` | [string](#string) | | the admin address who can update token mapping | |
Collaborator
There was a problem hiding this comment.
do we want multiple admins?
Contributor
Author
There was a problem hiding this comment.
Not sure, we can do that later if wanted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #119
Solution:
unit tests
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)