Skip to content

Problem: memiavl background snapshot writing don't limit concurrency level #1171

Merged
mmsqe merged 5 commits into
crypto-org-chain:mainfrom
jacksoom:main
Sep 19, 2023
Merged

Problem: memiavl background snapshot writing don't limit concurrency level #1171
mmsqe merged 5 commits into
crypto-org-chain:mainfrom
jacksoom:main

Conversation

@jacksoom

Copy link
Copy Markdown
Contributor

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@jacksoom
jacksoom requested a review from a team as a code owner September 18, 2023 04:56
@jacksoom
jacksoom requested review from devashishdxt and yihuang and removed request for a team September 18, 2023 04:56
Comment thread memiavl/db.go Outdated
Comment thread memiavl/export.go Outdated
Comment thread memiavl/db.go
@yihuang
yihuang enabled auto-merge September 18, 2023 05:36
@codecov

codecov Bot commented Sep 18, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1171 (0ff7bf2) into main (e6adb05) will increase coverage by 19.19%.
The diff coverage is 86.20%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1171       +/-   ##
===========================================
+ Coverage   14.84%   34.04%   +19.19%     
===========================================
  Files          77      113       +36     
  Lines        6764    11233     +4469     
===========================================
+ Hits         1004     3824     +2820     
- Misses       5677     7032     +1355     
- Partials       83      377      +294     
Files Changed Coverage Δ
memiavl/db.go 59.93% <82.35%> (ø)
memiavl/multitree.go 71.42% <85.71%> (ø)
memiavl/export.go 67.04% <100.00%> (ø)
memiavl/mmap.go 75.86% <100.00%> (ø)

... and 50 files with indirect coverage changes

@yihuang
yihuang added this pull request to the merge queue Sep 19, 2023
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 19, 2023
@yihuang
yihuang added this pull request to the merge queue Sep 19, 2023
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 19, 2023
@yihuang
yihuang added this pull request to the merge queue Sep 19, 2023
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 19, 2023
@mmsqe
mmsqe added this pull request to the merge queue Sep 19, 2023
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 19, 2023
@mmsqe
mmsqe added this pull request to the merge queue Sep 19, 2023
Merged via the queue into crypto-org-chain:main with commit f0a7f54 Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants