Problem: memiavl don't support rollback#1091
Merged
Merged
Conversation
yihuang
requested review from
devashishdxt and
mmsqe
and removed request for
a team
July 3, 2023 03:25
yihuang
commented
Jul 3, 2023
yihuang
commented
Jul 3, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| opts := rs.opts | ||
| opts.TargetVersion = uint32(target) |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
Closes: crypto-org-chain#1089 Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> Update memiavl/db.go Signed-off-by: yihuang <huang@crypto.com> revert int type changes
added 3 commits
July 3, 2023 11:42
| return snapshottypes.SnapshotItem{}, fmt.Errorf("version overflows uint32: %d", height) | ||
| } | ||
| snapshotDir := snapshotName(uint32(height)) | ||
| snapshotDir := snapshotName(int64(height)) |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
| return fmt.Errorf("snapshot is not created yet: height: %d", version) | ||
| } | ||
| mtree, err = LoadMultiTree(snapshotPath(db.dir, version), true, 0) | ||
| mtree, err = LoadMultiTree(filepath.Join(db.dir, snapshotName(int64(version))), true, 0) |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
| found bool | ||
| ) | ||
| if err := traverseSnapshots(root, false, func(version int64) (bool, error) { | ||
| if version <= int64(targetVersion) { |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
|
|
||
| // prune snapshots that's larger than the target version | ||
| if err := traverseSnapshots(dir, false, func(version int64) (bool, error) { | ||
| if version <= int64(opts.TargetVersion) { |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
|
|
||
| // truncate the WAL | ||
| opts.Logger.Info("truncate WAL from back, version: %d", opts.TargetVersion) | ||
| if err := wal.TruncateBack(walIndex(int64(opts.TargetVersion), mtree.initialVersion)); err != nil { |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
Codecov Report
@@ Coverage Diff @@
## main #1091 +/- ##
==========================================
+ Coverage 46.18% 46.55% +0.36%
==========================================
Files 80 80
Lines 7195 7250 +55
==========================================
+ Hits 3323 3375 +52
+ Misses 3516 3514 -2
- Partials 356 361 +5
|
mmsqe
approved these changes
Jul 3, 2023
Co-authored-by: mmsqe <mavis@crypto.com> Signed-off-by: yihuang <huang@crypto.com>
Co-authored-by: mmsqe <mavis@crypto.com> Signed-off-by: yihuang <huang@crypto.com>
Co-authored-by: mmsqe <mavis@crypto.com> Signed-off-by: yihuang <huang@crypto.com>
This was referenced Apr 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1089
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)