Problem: memiavl zero-copy don't work with inter-block cache#1035
Merged
Conversation
yihuang
commented
May 23, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| opts := rs.opts | ||
| opts.CreateIfMissing = true | ||
| opts.InitialStores = initialStores | ||
| opts.TargetVersion = uint32(version) |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
|
|
||
| return &Tree{ | ||
| version: uint32(version), | ||
| version: uint32(version), |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
| default: | ||
| // add tree | ||
| tree := NewWithInitialVersion(uint32(nextVersion(t.Version(), t.initialVersion))) | ||
| tree := NewWithInitialVersion(uint32(nextVersion(t.Version(), t.initialVersion)), t.cacheSize) |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
Solution: - ignore the inter-block cache silently - roll it's own cache in memiavl trees Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com>
yihuang
marked this pull request as ready for review
May 26, 2023 02:32
yihuang
requested review from
leejw51crypto and
mmsqe
and removed request for
a team
May 26, 2023 02:32
Codecov Report
@@ Coverage Diff @@
## main #1035 +/- ##
==========================================
- Coverage 46.55% 46.30% -0.25%
==========================================
Files 82 82
Lines 7091 7112 +21
==========================================
- Hits 3301 3293 -8
- Misses 3443 3470 +27
- Partials 347 349 +2
|
mmsqe
approved these changes
May 26, 2023
yihuang
enabled auto-merge
May 26, 2023 03:08
added 2 commits
May 26, 2023 11:16
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
May 26, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
May 26, 2023
This was referenced Apr 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)