Problem: local state-sync commands are not integrated#1027
Merged
Conversation
yihuang
commented
May 15, 2023
Codecov Report
@@ Coverage Diff @@
## main #1027 +/- ##
==========================================
+ Coverage 45.82% 46.17% +0.34%
==========================================
Files 82 82
Lines 6937 6937
==========================================
+ Hits 3179 3203 +24
+ Misses 3422 3397 -25
- Partials 336 337 +1
|
yihuang
marked this pull request as ready for review
May 15, 2023 08:27
yihuang
requested review from
JayT106,
devashishdxt and
mmsqe
and removed request for
a team
May 15, 2023 08:27
yihuang
commented
May 15, 2023
mmsqe
reviewed
May 15, 2023
mmsqe
left a comment
Contributor
There was a problem hiding this comment.
might need add rpc_servers as well
added 6 commits
May 15, 2023 20:50
Signed-off-by: yihuang <huang@crypto.com>
Signed-off-by: yihuang <huang@crypto.com>
13 tasks
mmsqe
reviewed
May 15, 2023
mmsqe
reviewed
May 15, 2023
Co-authored-by: mmsqe <tqd0800210105@gmail.com> Signed-off-by: yihuang <huang@crypto.com>
JayT106
approved these changes
May 15, 2023
mmsqe
reviewed
May 16, 2023
added 2 commits
May 16, 2023 14:27
yihuang
enabled auto-merge
May 16, 2023 06:59
mmsqe
approved these changes
May 16, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
May 16, 2023
13 tasks
This was referenced Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)