Skip to content

fix: staking cache to in-memory KV store #1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 66 commits into from
Nov 21, 2025
Merged

fix: staking cache to in-memory KV store #1733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
906fffd
perf: optimise staking endblocker (#1725)
randy-cro Oct 15, 2025
2e54144
normalize cache validator queue key to be UTC (#1730)
randy-cro Oct 23, 2025
96f6f40
try memory store wrapped in kvstore for unbonding delegations cache
randy-cro Nov 5, 2025
d7abbe8
add memory cache to unbonding validators and redelegations
randy-cro Nov 5, 2025
d55ef2e
remove ctx from getPrefix
randy-cro Nov 5, 2025
4cd03fe
remove ctx from getKey
randy-cro Nov 5, 2025
071196c
fix to make dirty true when setEntry is called and the cache is full
randy-cro Nov 5, 2025
aed502d
return empty slice as default for getEntry
randy-cro Nov 5, 2025
21c4204
fix tests
randy-cro Nov 5, 2025
886ad9c
correct fix: return empty slice for getEntry if entry cant be found/e…
randy-cro Nov 6, 2025
a9ad2ef
remove unneeded comments
randy-cro Nov 6, 2025
0cea463
panic should loadFromStore be nil
randy-cro Nov 6, 2025
02055f2
move storeService panic to within cacheEntry
randy-cro Nov 6, 2025
57a6738
fix cache tests
randy-cro Nov 6, 2025
d7b94e4
fix tests
randy-cro Nov 6, 2025
508cc67
gofumpt
randy-cro Nov 6, 2025
3f34a93
update CHANGELOG
randy-cro Nov 6, 2025
5c5e8a9
fix comment
randy-cro Nov 6, 2025
d030fcd
gofumpt
randy-cro Nov 6, 2025
aa515d0
remove unneeded comment
randy-cro Nov 6, 2025
c436d1b
fix tests
randy-cro Nov 6, 2025
aaca3f0
lint:rename CacheEntryType as EntryType to prevent import stuttering
randy-cro Nov 6, 2025
949e5f8
add mutex lock for methods
randy-cro Nov 6, 2025
cfa638d
move load check outside of cache entry to prevent deadlock, lint:refa…
randy-cro Nov 6, 2025
4d8f70e
minor refactor + gofumpt
randy-cro Nov 6, 2025
1a94d8b
fix iterator race + possible race in checkreloading
randy-cro Nov 6, 2025
fde5f2f
add dirty load checks to prevent reloading more than once
randy-cro Nov 6, 2025
ea0d1cf
fix race issues due to gas in tests
randy-cro Nov 6, 2025
67a2631
fix error logs
randy-cro Nov 7, 2025
3d62029
add debug logs (to be removed)
randy-cro Nov 7, 2025
79f0c39
test out gaslessContext
randy-cro Nov 10, 2025
5957074
Revert "test out gaslessContext"
randy-cro Nov 10, 2025
f7b7a24
Revert "add debug logs (to be removed)"
randy-cro Nov 10, 2025
8f013a5
set dirty flag to true as soon as the cache is full
randy-cro Nov 11, 2025
d57c03f
use already present noopGasMeter
randy-cro Nov 11, 2025
346a32d
add debug logs (to be removed)
randy-cro Nov 11, 2025
5ec4fe8
remove unused import
randy-cro Nov 11, 2025
c763e9b
fix import
randy-cro Nov 11, 2025
79ed9a2
Revert "use already present noopGasMeter"
randy-cro Nov 11, 2025
11ff239
Revert "remove unused import"
randy-cro Nov 11, 2025
1a1d363
Revert "fix import"
randy-cro Nov 11, 2025
7b31c16
Revert "add debug logs (to be removed)"
randy-cro Nov 11, 2025
a938fbe
Reapply "add debug logs (to be removed)"
randy-cro Nov 11, 2025
61f9b54
move dirty,full flag to store, remove count
randy-cro Nov 11, 2025
d1886d8
fix test
randy-cro Nov 11, 2025
173aada
refactor
randy-cro Nov 12, 2025
8fba234
use baseapp noopgasmeter
randy-cro Nov 12, 2025
19be09c
add more tests
randy-cro Nov 12, 2025
e1a171b
refactor
randy-cro Nov 12, 2025
be1195f
update CHANGELOG
randy-cro Nov 13, 2025
bfb2785
fix delegation test
randy-cro Nov 17, 2025
e049d43
Merge branch 'release/v0.50.x' into fix/staking-optimization
randy-cro Nov 19, 2025
015c17b
simplify CHANGELOG
randy-cro Nov 19, 2025
c835be4
make changelog clearer
randy-cro Nov 19, 2025
aa1a97b
short circuit return full error when setting if the cache is already …
randy-cro Nov 20, 2025
6320058
disable cache should there be an unexpected error
randy-cro Nov 20, 2025
65c1a39
refactor to have checkReload to be an entry method
randy-cro Nov 20, 2025
2d3a74f
deleting an key that exists doesn't require recount and can immediate…
randy-cro Nov 20, 2025
4071f13
refactor checkReload to short circuit and return max error if data le…
randy-cro Nov 20, 2025
fc55b61
move max check to get and getAll instead of polluting checkReload
randy-cro Nov 21, 2025
2cc54ab
isFull is set when count hits the max, but isDirty should only be tru…
randy-cro Nov 21, 2025
739e554
refactor ErrCacheIsFullAndDirty to ErrCacheExceededCapacity
randy-cro Nov 21, 2025
9106690
add sorting when loading from store for deterministic results
randy-cro Nov 21, 2025
39aa5bf
refactor CacheMetadata to Metadata
randy-cro Nov 21, 2025
3812e93
add comment
randy-cro Nov 21, 2025
b3fa925
fix lint: update proto with comment
randy-cro Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

### Features

* (x/staking) [#1733](https://github.com/crypto-org-chain/cosmos-sdk/pull/1730) Optimize staking endblocker execution by caching queue entries from iterators via an in-memory KV store to ensure rollback on discarded contexts.
* (baseapp) [#205](https://github.com/crypto-org-chain/cosmos-sdk/pull/205) Add `TxExecutor` baseapp option, add `TxIndex`/`TxCount`/`MsgIndex`/`BlockGasUsed` fields to `Context, to support tx parallel execution.
* (baseapp) [#206](https://github.com/crypto-org-chain/cosmos-sdk/pull/206) Support mount object store in baseapp, add `ObjectStore` api in context, [#585](https://github.com/crypto-org-chain/cosmos-sdk/pull/585) Skip snapshot for object store.
* (bank) [#237](https://github.com/crypto-org-chain/cosmos-sdk/pull/237) Support virtual accounts in sending coins.
Expand Down
Loading
Loading