Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Promote MSSQLVirtualNetworkRule and MSSQLDatabase to v1alpha2#193

Merged
ulucinar merged 2 commits into
crossplane-contrib:mainfrom
ytsarev:mssql-resources
Jul 5, 2022
Merged

Promote MSSQLVirtualNetworkRule and MSSQLDatabase to v1alpha2#193
ulucinar merged 2 commits into
crossplane-contrib:mainfrom
ytsarev:mssql-resources

Conversation

@ytsarev
Copy link
Copy Markdown
Collaborator

@ytsarev ytsarev commented Jul 1, 2022

Description of your changes

Promote MSSQLVirtualNetworkRule and MSSQLDatabase to v1alpha2

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

k get -f ./examples/sql/mssqlvirtualnetworkrule.yaml
NAME                                                          READY   SYNCED   EXTERNAL-NAME   AGE
mssqlvirtualnetworkrule.sql.azure.jet.crossplane.io/example   True    True     example         3h25m

NAME                                                   READY   SYNCED   EXTERNAL-NAME    AGE
resourcegroup.azure.jet.crossplane.io/example-sql-rg   True    True     example-sql-rg   3h43m

NAME                                                        READY   SYNCED   EXTERNAL-NAME   AGE
virtualnetwork.network.azure.jet.crossplane.io/example-vn   True    True     example-vn      3h43m

NAME                                                    READY   SYNCED   EXTERNAL-NAME    AGE
subnet.network.azure.jet.crossplane.io/example-subnet   True    True     example-subnet   3h43m

NAME                                                           READY   SYNCED   EXTERNAL-NAME          AGE
mssqlserver.sql.azure.jet.crossplane.io/mssql-server-example   True    True     mssql-server-example   3h25m

NAME                    TYPE     DATA   AGE
secret/mssql-password   Opaque   1      3h43m

k get -f examples/sql/mssqldatabase.yaml
NAME      READY   SYNCED   EXTERNAL-NAME   AGE
example   True    True     example         6m24s

ytsarev added 2 commits July 1, 2022 13:43
Signed-off-by: Yury Tsarev <yury@upbound.io>
Signed-off-by: Yury Tsarev <yury@upbound.io>
@ytsarev ytsarev requested a review from ulucinar July 1, 2022 14:54
Copy link
Copy Markdown
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ytsarev, lgtm.

@ulucinar ulucinar merged commit c37d1bb into crossplane-contrib:main Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants