Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Append the Crossplane provider name to the Terraform user agent#180

Merged
negz merged 1 commit intocrossplane-contrib:mainfrom
clareliguori:user-agent
Apr 1, 2022
Merged

Append the Crossplane provider name to the Terraform user agent#180
negz merged 1 commit intocrossplane-contrib:mainfrom
clareliguori:user-agent

Conversation

@clareliguori
Copy link
Contributor

Signed-off-by: Clare Liguori liguori@amazon.com

Description of your changes

Related to crossplane-contrib/provider-aws#1241, this updates the user agent that Terraform uses for AWS requests, so they can be disambiguated in CloudTrail from other Terraform requests that may use the same credentials/role.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Created an ECR repo using the provider and got the following user agent in CloudTrail:

"userAgent": "APN/1.0 HashiCorp/1.0 Terraform/1.0.5 (+https://www.terraform.io) terraform-provider-aws/3.56.0 (+https://registry.terraform.io/providers/hashicorp/aws) aws-sdk-go/1.40.29 (go1.16; linux; amd64) crossplane-provider-jet-aws/v0.4.0-30.g2f6b907c.dirty"

Signed-off-by: Clare Liguori <liguori@amazon.com>
@negz
Copy link
Member

negz commented Apr 1, 2022

Thanks @clareliguori! Glad this was more straightforward than I had feared. 😄

@negz negz merged commit f10bf3e into crossplane-contrib:main Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants