This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add External Secret Stores support as an alpha feature #179
Merged
turkenh merged 4 commits intocrossplane-contrib:mainfrom Apr 5, 2022
Merged
Add External Secret Stores support as an alpha feature #179turkenh merged 4 commits intocrossplane-contrib:mainfrom
turkenh merged 4 commits intocrossplane-contrib:mainfrom
Conversation
turkenh
requested review from
ezgidemirel,
muvaf and
sergenyalcin
and removed request for
muvaf
13 tasks
muvaf
approved these changes
Apr 5, 2022
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds External Secret Stores support as an alpha feature.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested by creating an IAM AccessKey and ensuring connection secrets land in Vault. Similarly, validated the cleanup with the deletion of the resource.