This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Fix controller environment#178
Merged
turkenh merged 1 commit intocrossplane-contrib:mainfrom Mar 28, 2022
Merged
Conversation
Signed-off-by: Hasan Turken <[email protected]>
turkenh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Currently installations from master branch fails with the following logs:
This PR fixes this issue by passing the required environment to the controller at runtime. It also set
DOCKER_REGISTRYonly if not set to be able to test locally built image.As reported by a community member on slack.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Installed the controller using a provider image from this PR.