This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Fix external name configuration for ECS Service#173
Merged
turkenh merged 1 commit intocrossplane-contrib:mainfrom Mar 17, 2022
Merged
Fix external name configuration for ECS Service#173turkenh merged 1 commit intocrossplane-contrib:mainfrom
turkenh merged 1 commit intocrossplane-contrib:mainfrom
Conversation
0ecc523 to
7079281
Compare
ulucinar
approved these changes
Mar 17, 2022
ulucinar
reviewed
Mar 17, 2022
Fixes crossplane-contrib#170 Signed-off-by: Hasan Turken <turkenh@gmail.com> (cherry picked from commit 39932472c6cd6bba3db75bdb4b8ae674fcabf995)
7079281 to
c8ac7d8
Compare
|
Successfully created backport PR #175 for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR fixes ECS Service external name configuration and adds a working/tested example.
Fixes #170
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Using the (renamed) example manifest which is also added in this PR.