This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Merged
Conversation
5bbcc3b to
e64ae27
Compare
muvaf
approved these changes
Mar 14, 2022
| toPort: | ||
| format: int64 | ||
| type: integer | ||
| required: |
Member
There was a problem hiding this comment.
Why are these not required anymore?
Collaborator
Author
There was a problem hiding this comment.
They're not marked as "required": true in the cli schema. I generated preview CRDs and noticed the same change in some of the other resources too.
Member
There was a problem hiding this comment.
Could you note this case here or open an issue so that we can investigate it? Ideally, we shouldn't lose any information due to conversions done by TF CLI or us. Noting it down somewhere would help us know what to fix without trying again.
muvaf
reviewed
Mar 14, 2022
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
e64ae27 to
b4fd504
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This change updates the provider to use CLI schema. This change is on top of this PR.
Fixes #166
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Created/deleted KMS, Neptune Cluster and Neptune Instance resources.