This repository was archived by the owner on Dec 15, 2022. It is now read-only.
fix(makefile): added needed export vars#161
Merged
muvaf merged 1 commit intocrossplane-contrib:mainfrom Feb 7, 2022
Merged
Conversation
muvaf
reviewed
Feb 6, 2022
haarchri
force-pushed
the
fix/makefile
branch
from
b834417 to
c7920d1
Compare
Signed-off-by: haarchri <chhaar30@googlemail.com>
haarchri
force-pushed
the
fix/makefile
branch
from
c7920d1 to
d8b8734
Compare
Member
Author
|
@muvaf something more required here ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: haarchri chhaar30@googlemail.com
Description of your changes
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested