This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Manually configured resources to be v1alpha2#144
Merged
muvaf merged 3 commits intocrossplane-contrib:mainfrom Jan 6, 2022
Merged
Manually configured resources to be v1alpha2#144muvaf merged 3 commits intocrossplane-contrib:mainfrom
muvaf merged 3 commits intocrossplane-contrib:mainfrom
Conversation
Signed-off-by: Muvaffak Onus <me@muvaf.com>
Signed-off-by: Muvaffak Onus <me@muvaf.com>
ulucinar
approved these changes
Jan 6, 2022
Collaborator
ulucinar
left a comment
ulucinar
left a comment
There was a problem hiding this comment.
LGTM after linter issues are resolved.
Signed-off-by: Muvaffak Onus <me@muvaf.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Only
route53resolveris not marked as such because its inclusion in the minimal set wasn't intended anyway and it has no manual configuration.Fixes #143
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
make reviewableand inspection of the example YAMLs.