This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Final API groups and kind names#139
Merged
muvaf merged 3 commits intocrossplane-contrib:mainfrom Jan 4, 2022
Merged
Conversation
Signed-off-by: Muvaffak Onus <[email protected]>
… with a script Signed-off-by: Muvaffak Onus <[email protected]>
Signed-off-by: Muvaffak Onus <[email protected]>
Merged
2 tasks
turkenh
reviewed
Jan 4, 2022
| "aws_route53_resolver_rule_association": ReplaceGroupWords("route53resolver", 2), | ||
| "aws_route_table": ReplaceGroupWords("ec2", 0), | ||
| "aws_route_table_association": ReplaceGroupWords("ec2", 0), | ||
| "aws_s3_access_point": ReplaceGroupWords("s3control", 1), |
Collaborator
There was a problem hiding this comment.
Should this go under s3 group?
Member
Author
There was a problem hiding this comment.
Nope, it's actually s3control. https://docs.aws.amazon.com/sdk-for-go/api/service/s3control/#S3Control.CreateAccessPoint
turkenh
approved these changes
Jan 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
I have utilized @turkenh 's suggestion to use the grouping here which matches AWS Go SDK. In order to do that, I have written a small script that will print it in the format I'd like. With this script, we were able to get all cases where the calculated group differed from the group we want.
Then I added a function that is used to calculated the correct kind with manual input of word count that needs to be eliminated, called
ReplaceGroupWords. In the end, we have minimized the manual input for kind and group to very few.The most relevant commits are the first two.
Depends on crossplane/terrajet#183
Fixes #133
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I have printed all groups and kinds and manually inspected the list. Please do inspect the list to see if you can catch anything I missed.
API groups and kinds