This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add Route53 group and missing Elasticache resources#130
Merged
muvaf merged 4 commits intocrossplane-contrib:mainfrom Nov 19, 2021
Merged
Add Route53 group and missing Elasticache resources#130muvaf merged 4 commits intocrossplane-contrib:mainfrom
muvaf merged 4 commits intocrossplane-contrib:mainfrom
Conversation
Signed-off-by: Muvaffak Onus <[email protected]>
Signed-off-by: Muvaffak Onus <[email protected]>
Signed-off-by: Muvaffak Onus <[email protected]>
ulucinar
approved these changes
Nov 19, 2021
config/route53/config.go
Outdated
| Type: "Zone", | ||
| }, | ||
| "key_management_service_arn": config.Reference{ | ||
| Type: "github.com/crossplane-contrib/provider-jet-aws/apis/kms/v1alpha1.Key", |
Collaborator
There was a problem hiding this comment.
Is the default extractor okay in this case?
Member
Author
There was a problem hiding this comment.
It wasn't. Just added an ARN extractor for KMS key ee98973
| // Z123456ABCDEFG:vpc-12345678 | ||
| // Z123456ABCDEFG:vpc-12345678:us-east-2 | ||
| r.ExternalName.SetIdentifierArgumentFn = func(base map[string]interface{}, externalName string) { | ||
| words := strings.Split(externalName, ":") |
Collaborator
There was a problem hiding this comment.
Like we discussed for other configuration functions, being able to report errors really paves off. But this is not an issue of this PR.
Member
Author
There was a problem hiding this comment.
It's hard to know whether it's an error case though. For example, in this case the ID comes from the provider, hence it can be empty until creation finishes so until then there is no data to set and it's a valid flow. So, specifically for this SetIdentifierArgumentFn, having a best-effort approach is more inline than returning error IMO.
Signed-off-by: Muvaffak Onus <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds
route53and two elasticache resources that were missing. I'll add more until we get to around 100.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Code compiles.