This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Complete the update to latest Terrajet version#128
Merged
muvaf merged 13 commits intocrossplane-contrib:mainfrom Nov 18, 2021
Merged
Complete the update to latest Terrajet version#128muvaf merged 13 commits intocrossplane-contrib:mainfrom
muvaf merged 13 commits intocrossplane-contrib:mainfrom
Conversation
Signed-off-by: Hasan Turken <[email protected]> (cherry picked from commit 9219249ee6584bf06ca6577ea1f969e379b57dd0)
Signed-off-by: Muvaffak Onus <[email protected]>
Signed-off-by: Muvaffak Onus <[email protected]>
Signed-off-by: Muvaffak Onus <[email protected]>
Signed-off-by: Muvaffak Onus <[email protected]>
2 tasks
…me files we need Signed-off-by: Muvaffak Onus <[email protected]>
…iles Signed-off-by: Muvaffak Onus <[email protected]>
Signed-off-by: Muvaffak Onus <[email protected]>
Signed-off-by: Muvaffak Onus <[email protected]>
3 tasks
turkenh
reviewed
Nov 18, 2021
| cobertura: | ||
| @cat $(GO_TEST_OUTPUT)/coverage.txt | \ | ||
| grep -v zz_generated.deepcopy | \ | ||
| grep -v zz_ | \ |
Collaborator
There was a problem hiding this comment.
good idea, should we reflect to tf-template?
Member
Author
There was a problem hiding this comment.
| //go:generate find ../internal/controller -type d -empty -delete | ||
|
|
||
| // NOTE(muvaf): Some of Terraform AWS provider files have "!generate" build tag | ||
| // that prevent us from using it for generator program. |
Collaborator
There was a problem hiding this comment.
Does this cause any problem?
Member
Author
There was a problem hiding this comment.
No, it's just that we can't use generate build tag like we do in other generation tools we have here.
| r.ShortGroup = "ec2" | ||
| case r.ShortGroup == "vpc": | ||
| r.ShortGroup = "ec2" | ||
| case name == "aws_lb_": |
Collaborator
There was a problem hiding this comment.
Suggested change
| case name == "aws_lb_": | |
| case strings.HasPrefix(name, "aws_lb"): |
Member
Author
There was a problem hiding this comment.
I added a map with regexes and it covers both.
turkenh
reviewed
Nov 18, 2021
Signed-off-by: Muvaffak Onus <[email protected]>
Signed-off-by: Muvaffak Onus <[email protected]>
turkenh
approved these changes
Nov 18, 2021
Signed-off-by: Muvaffak Onus <[email protected]>
Signed-off-by: Muvaffak Onus <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Updates all configs to match the new interfaces and updates Terrajet. There are a few small things like running Terrajet from
go:generatethat I'll open PRs in providertf-template.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Manually.