This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add doc for adding new resources#123
Merged
turkenh merged 6 commits intocrossplane-contrib:mainfrom Oct 21, 2021
turkenh:how-to-contribute
Merged
Add doc for adding new resources#123turkenh merged 6 commits intocrossplane-contrib:mainfrom turkenh:how-to-contribute
turkenh merged 6 commits intocrossplane-contrib:mainfrom
turkenh:how-to-contribute
Conversation
Signed-off-by: Hasan Turken <[email protected]>
turkenh
commented
Oct 19, 2021
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Collaborator
|
@turkenh Do mind moving the contribution guide into a separate file? This would unclutter the landing page. Edit: Move most of the content to custom-configuration.md and just have one link in the main readme? |
Collaborator
Author
Collaborator
Author
Yes, correct 👍 |
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
ulucinar
added a commit
to ulucinar/provider-jet-azure
that referenced
this pull request
Oct 22, 2021
- Cherry-picked from crossplane-contrib/provider-jet-aws#123 by @turkenh - Extended the late-initialization section with an example use-case Signed-off-by: Alper Rifat Ulucinar <[email protected]>
2 tasks
ulucinar
added a commit
to ulucinar/provider-jet-azure
that referenced
this pull request
Oct 22, 2021
- Cherry-picked from crossplane-contrib/provider-jet-aws#123 by @turkenh - Extended the late-initialization section with an example use-case Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar
added a commit
to ulucinar/provider-jet-azure
that referenced
this pull request
Oct 22, 2021
- Cherry-picked from crossplane-contrib/provider-jet-aws#123 by @turkenh - Extended the late-initialization section with an example use-case - Adjustments specific to provider-tf-azure Signed-off-by: Alper Rifat Ulucinar <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Resolves #118
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
N/A