This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Use strong-typed functions as external name configurer instead of func path#122
Merged
muvaf merged 3 commits intocrossplane-contrib:mainfrom Oct 20, 2021
Merged
Conversation
3 tasks
turkenh
reviewed
Oct 20, 2021
config/autoscaling/config.go
Outdated
| }, | ||
| }, | ||
| Kind: "AutoscalingGroup", | ||
| ExternalName: common.ExternalNameAsName, |
muvaf
force-pushed
the
name-me-from-the-outside
branch
from
c047fdc to
25aee2f
Compare
…funcs Signed-off-by: Muvaffak Onus <me@muvaf.com>
Signed-off-by: Muvaffak Onus <me@muvaf.com>
muvaf
force-pushed
the
name-me-from-the-outside
branch
from
25aee2f to
47cb6c0
Compare
Member
Author
|
@turkenh ready for review |
Signed-off-by: Muvaffak Onus <me@muvaf.com>
muvaf
force-pushed
the
name-me-from-the-outside
branch
from
c10ba05 to
3ef3441
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Application of the changes in crossplane/terrajet#124
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested during crossplane/terrajet#124