This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Remove region from iam group resource spec#113
Merged
turkenh merged 1 commit intocrossplane-contrib:mainfrom Oct 16, 2021
turkenh:fix-iam-region
Merged
Remove region from iam group resource spec#113turkenh merged 1 commit intocrossplane-contrib:mainfrom turkenh:fix-iam-region
turkenh merged 1 commit intocrossplane-contrib:mainfrom
turkenh:fix-iam-region
Conversation
Fixes #112 Signed-off-by: Hasan Turken <turkenh@gmail.com>
luebken
approved these changes
Oct 16, 2021
Collaborator
luebken
left a comment
luebken
left a comment
There was a problem hiding this comment.
LGTM but haven't tested.
ulucinar
approved these changes
Oct 16, 2021
|
Successfully created backport PR #114 for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
IAM group resources do not have a region hence do not need a
regionfield in their schema. This PR removes schema field fromiamgroup resources.Fixes #112
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
kubectl create -f examples/iam/user.yamlkubectl delete -f examples/iam/user.yaml