added string transform join#133
Merged
jeanduplessis merged 5 commits intocrossplane-contrib:mainfrom Jul 30, 2024
Merged
Conversation
gschei
force-pushed
the
add-transform-join
branch
from
16260c6 to
f66a8ac
Compare
Signed-off-by: Gilbert Scheiblhofer <gilbert.scheiblhofer@gmx.at>
Signed-off-by: Gilbert Scheiblhofer <gilbert.scheiblhofer@gmx.at>
Signed-off-by: Gilbert Scheiblhofer <gilbert.scheiblhofer@gmx.at>
gschei
force-pushed
the
add-transform-join
branch
from
ede6fce to
dd8772f
Compare
negz
approved these changes
Jul 10, 2024
Member
|
Thank you! |
Signed-off-by: Gilbert Scheiblhofer <gilbert.scheiblhofer@gmx.at>
Contributor
|
@gschei would you mind resolving the conflicts? We're ready to release a new version of this function and would like to include this work. |
Signed-off-by: Gilbert Scheiblhofer <gilbert.scheiblhofer@gmx.at>
Contributor
Author
|
@jeanduplessis sure, done! |
StuporHero
added a commit
to StuporHero/function-patch-and-transform
that referenced
this pull request
Mar 6, 2026
The Join string transform type was added in v0.7.0 (crossplane-contrib#133) and Replace was added later, but the kubebuilder validation enum marker on StringTransform.Type was not updated to include them. This causes CRD schema validation to reject valid Compositions using these transform types. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
StuporHero
added a commit
to StuporHero/function-patch-and-transform
that referenced
this pull request
Mar 6, 2026
The Join string transform type was added in v0.7.0 (crossplane-contrib#133) and Replace was added later, but the kubebuilder validation enum marker on StringTransform.Type was not updated to include them. This causes CRD schema validation to reject valid Compositions using these transform types. Signed-off-by: Michael Juliano <michaelj@sunsofterp.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implements issue #119