shared: point users at cargo and cross-toolchains in no-image error#1775
Open
c-tonneslan wants to merge 1 commit into
Open
shared: point users at cargo and cross-toolchains in no-image error#1775c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
When `cross` runs against a target it doesn't ship an image for (typical examples: x86_64-apple-darwin, x86_64-pc-windows-msvc) the error just told the user to specify a custom image in Cross.toml, which isn't very actionable if you don't already know what an image for that target looks like. Two cases that come up a lot: - target == host (or basically host, like macOS-on-macOS). Plain cargo already works. - target needs the proprietary Apple/MSVC SDKs. The community cross-toolchains repo has Dockerfiles for that. Mention both in the error so people can find their next step without having to ask in chat. Closes cross-rs#1447. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1447.
The current error when
crossdoesn't have a Docker image for a target (e.g.x86_64-apple-darwinorx86_64-pc-windows-msvc) just tells you to specify a custom image in Cross.toml:That's not very actionable. Two cases I keep running into:
cargo buildworks.Mention both in the message so people can find their next step without having to dig through the issue tracker or matrix room.