Open
Conversation
Signed-off-by: Connor Roos <[email protected]>
There was a problem hiding this comment.
Pull request overview
Adds Debian packaging support to build an ASAN-instrumented variant of the SWSS packages, aligning build outputs with an asan build profile and updating install/strip rules accordingly.
Changes:
- Introduces
swss-asanandswss-dbg-asanbinary packages gated by Debian build profiles. - Updates
debian/rulesto install/strip into package-name-specific directories based on anENABLE_ASANtoggle. - Adds conflicts/build-profile metadata to prevent ASAN and non-ASAN packages from being built/installed together.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
debian/rules |
Switches install destdir and dbg-package name to swss(-dbg)-asan when ASAN is enabled. |
debian/control |
Adds ASAN-specific binary package stanzas and uses Build-Profiles to select ASAN vs non-ASAN packages. |
Signed-off-by: Connor Roos <[email protected]>
Signed-off-by: Connor Roos <[email protected]>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a separate ASAN swss build package to be created as the target when DEB_BUILD_PROFILES=asan. This is required for Clobbering of ASAN after a standard swss build on the same build machine.