Open
Conversation
Signed-off-by: Connor Roos <croos@nvidia.com>
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Debian packaging variant intended for ASAN-instrumented builds of syncd, and also updates VPP virtual-switch code paths (ACL binding behavior and VPP stats dump cleanup) within vslib.
Changes:
- Add a new
syncd-asanbinary package and adjustdh_installbehavior based onDEB_BUILD_PROFILES=asan. - Fix VPP stats dump cleanup paths to free VPP vectors and disconnect on early-return cases.
- Refactor VPP ACL handling: introduce a placeholder “empty ACL” for tables and a shared default permit ACL, plus change table-group member bind ordering based on priority.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| vslib/vpp/vppxlate/SaiVppStats.c | Ensures VPP stats query resources (patterns, dir, connection) are released on failure paths. |
| vslib/vpp/SwitchVppAcl.cpp | Introduces placeholder ACL creation and shared default ACL logic; changes group-member update flow and binding order. |
| vslib/vpp/SwitchVpp.h | Adds state for shared default ACL (m_acl_default_swindex, m_acl_default_created) and renames the helper API. |
| debian/rules | Switches dh_install exclusions based on whether asan profile is active. |
| debian/control | Adds syncd-asan package stanza and adjusts profiles/conflicts for syncd. |
Signed-off-by: Connor Roos <croos@nvidia.com>
Signed-off-by: Connor Roos <croos@nvidia.com>
2 tasks
Signed-off-by: Connor Roos <croos@nvidia.com>
Signed-off-by: Connor Roos <croos@nvidia.com>
Signed-off-by: Connor Roos <croos@nvidia.com>
Comment on lines
+17
to
+20
| Package: syncd-asan | ||
| Architecture: any | ||
| Build-Profiles: <syncd asan !vs !rpc> | ||
| Depends: ${misc:Pre-Depends} |
Comment on lines
+48
to
+50
| Section: debug | ||
| Priority: extra | ||
| Depends: syncd (= ${binary:Version}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a separate ASAN syncd build package to be created as the target when DEB_BUILD_PROFILES=asan. This is required for Clobbering of ASAN after a standard swss build on the same build machine.