Skip to content

chore: fix all cargo clippy suggestions#53

Merged
berkus merged 2 commits intocriterion-rs:masterfrom
berestovskyy:andriy/fix-clippy
Feb 9, 2026
Merged

chore: fix all cargo clippy suggestions#53
berkus merged 2 commits intocriterion-rs:masterfrom
berestovskyy:andriy/fix-clippy

Conversation

@berestovskyy
Copy link
Contributor

Running:

% cargo --version
cargo 1.86.0 (adf9b6ad1 2025-02-28)
% cargo clippy --workspace --all-targets -- -D warnings

The cargo clippy CI workflow will be enabled in a subsequent PR.

Running:
```
% cargo --version
cargo 1.86.0 (adf9b6ad1 2025-02-28)
% cargo clippy --workspace --all-targets -- -D warnings
```
@berkus berkus enabled auto-merge (rebase) February 9, 2026 10:21
@berkus
Copy link
Contributor

berkus commented Feb 9, 2026

@berestovskyy looks like there are couple compile errors in bencher.rs

auto-merge was automatically disabled February 9, 2026 11:26

Head branch was pushed to by a user without write access

@berestovskyy
Copy link
Contributor Author

berestovskyy commented Feb 9, 2026

Thanks, @berkus, should be fixed now. It seems the CI strategy is to run cargo build with stable, all, and no features, then run cargo clippy with default features only.

@berkus
Copy link
Contributor

berkus commented Feb 9, 2026

Oh, we need to update clippy to run with all the combinations too.

@berestovskyy
Copy link
Contributor Author

The clippy and rustfmt CI steps are currently disabled due to unreachable condition: if: ${{ matrix.rust == 'stable' }}. Let's merge this PR now, and I'll prepare a follow-up to enable rustfmt, clippy across four feature sets: none, default, stable, and all (nightly builds only). We can also remove the cargo build steps to save time.

I'd prefer to handle the CI configuration in a separate PR, as it's impossible to replicate locally and may require a few iterations (and potentially your help) to get it passing. Sounds good?

@berkus berkus merged commit 9fdb024 into criterion-rs:master Feb 9, 2026
5 checks passed
@berkus
Copy link
Contributor

berkus commented Feb 9, 2026

Thanks for taking time to fix this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants