Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes support for the async-std runtime from Criterion.rs. The change consolidates async runtime support to focus on Tokio, Smol, and Futures executors only.
- Removed the
async_stdfeature flag and its associatedAsyncStdExecutorimplementation - Removed
async-stddependency from Cargo.toml - Updated documentation to reflect that async-std is no longer supported
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/async_executor.rs | Removed AsyncStdExecutor struct and its AsyncExecutor trait implementation along with related documentation comments |
| book/src/user_guide/benchmarking_async.md | Removed async-std from the supported executors table in the user guide |
| Cargo.toml | Removed async-std dependency, async_std feature flag, and references from the stable feature set and docs.rs metadata |
| Cargo.lock | Removed async-std package and its transitive dependencies that are no longer needed |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
It has been dead for a while.
berkus
force-pushed
the
feat/drop-async-std
branch
from
14fac81 to
15bddd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has been dead for a while.