Skip to content

don't fix mysql-connector-python version#39

Merged
cpaillet merged 1 commit intocriteo:masterfrom
cpaillet:master
Dec 15, 2021
Merged

don't fix mysql-connector-python version#39
cpaillet merged 1 commit intocriteo:masterfrom
cpaillet:master

Conversation

@cpaillet
Copy link
Copy Markdown
Contributor

@cpaillet cpaillet commented Jul 9, 2021

No description provided.

@Djailla
Copy link
Copy Markdown

Djailla commented Nov 23, 2021

Why setting a fixed version there ?

As a lib, this should not be a specific one

@cpaillet
Copy link
Copy Markdown
Contributor Author

version is no more fixed

@cpaillet cpaillet changed the title Bump mysql-connector-python to 8.0.25 Bump mysql-connector-python to 8.0.27 Dec 15, 2021
set version as >= to be able to have another up-to-date version when
using ipam libs
@cpaillet cpaillet changed the title Bump mysql-connector-python to 8.0.27 don't fix mysql-connector-python version Dec 15, 2021
mougams
mougams previously approved these changes Dec 15, 2021
@mougams mougams dismissed their stale review December 15, 2021 16:01

Discussion ongoing internally

@cpaillet cpaillet requested a review from kpetremann December 15, 2021 16:14
Copy link
Copy Markdown

@mougams mougams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to pin nono before merging this

@cpaillet cpaillet merged commit 3de0448 into criteo:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants