Skip to content

Make sure that all tests will pass even when not connected to the internet#107

Merged
fmigneault merged 2 commits into
masterfrom
offline-tests
Aug 16, 2025
Merged

Make sure that all tests will pass even when not connected to the internet#107
fmigneault merged 2 commits into
masterfrom
offline-tests

Conversation

@mishaschwartz
Copy link
Copy Markdown
Contributor

No description provided.

Comment on lines +14 to +15
body:
string: "{\n \"$schema\": \"http://json-schema.org/draft-07/schema#\",\n \"$id\":
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to load this content from another JSON file or have it directly embedded as JSON with newlines to improve readability?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really if we want to use the pytest-recording package. This is how it caches responses.

If it is crucial that this is more readable then we need to come up with a custom solution.

I would suggest that if you want to read more easily you can always copy/paste it into python console and json.loads the string.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! can you make an issue about that and we'll do something about it later on

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator

@huard huard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this add a new dependency that should be included somewhere ?

Please add a few lines in the developer doc to explain what this does and how to use it.

@mishaschwartz
Copy link
Copy Markdown
Contributor Author

Doesn't this add a new dependency that should be included somewhere ?

No, we are already using pytest-recorder elsewhere in this project. It just wasn't being used consistently.

@fmigneault fmigneault merged commit 78eedd5 into master Aug 16, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants