Make sure that all tests will pass even when not connected to the internet#107
Conversation
| body: | ||
| string: "{\n \"$schema\": \"http://json-schema.org/draft-07/schema#\",\n \"$id\": |
There was a problem hiding this comment.
Is there any way to load this content from another JSON file or have it directly embedded as JSON with newlines to improve readability?
There was a problem hiding this comment.
Not really if we want to use the pytest-recording package. This is how it caches responses.
If it is crucial that this is more readable then we need to come up with a custom solution.
I would suggest that if you want to read more easily you can always copy/paste it into python console and json.loads the string.
There was a problem hiding this comment.
Looks like we just need to register the serializer/deserializer:
Found from kevin1024/vcrpy#580
There was a problem hiding this comment.
cool! can you make an issue about that and we'll do something about it later on
huard
left a comment
There was a problem hiding this comment.
Doesn't this add a new dependency that should be included somewhere ?
Please add a few lines in the developer doc to explain what this does and how to use it.
No, we are already using pytest-recorder elsewhere in this project. It just wasn't being used consistently. |
No description provided.