Application layout: Refactor core tool functions to separate module

[amotl]

Not using Python decorators on tool functions improves testing on newer releases of FastMCP by making many details of GH-47 obsolete, i.e. the test suite does not need to learn async.

[coderabbitai]

Warning

Rate limit exceeded

@amotl has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 19 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 9901015 and 176f2aa.

📒 Files selected for processing (4)

• cratedb_mcp/__main__.py (1 hunks)
• cratedb_mcp/tool.py (1 hunks)
• pyproject.toml (1 hunks)
• tests/test_mcp.py (2 hunks)

Walkthrough

The codebase refactors tool registration for the FastMCP application by moving tool logic into a new tool.py module. Functions for querying CrateDB and documentation are now imported and registered centrally. Tests and imports are updated accordingly, and the fastmcp dependency version range is broadened in the project configuration.

Changes

File(s)	Change Summary
cratedb_mcp/main.py	Refactored to import and register tools from tool.py instead of inline definitions and decorators.
cratedb_mcp/tool.py	New module consolidating CrateDB query and documentation functions with validation and error handling.
tests/test_mcp.py	Updated imports and patch targets to reference tool.py instead of __main__.py.
pyproject.toml	Broadened fastmcp dependency version range from <2.7 to >=2.7,<2.10.

Sequence Diagram(s)

sequenceDiagram
    participant Main as __main__.py
    participant Tool as tool.py
    participant MCP as FastMCP

    Main->>Tool: Import tool functions (e.g., query_sql, get_table_metadata)
    Main->>MCP: Register tools using Tool.from_function
    MCP->>Tool: On tool invocation, call corresponding function
    Tool->>CrateDB: Send HTTP requests for SQL queries or metadata
    Tool->>Documentation: Fetch or index documentation as needed
    Tool-->>MCP: Return results

Loading

Possibly related PRs

• Chore: Add software test about trailing slash on HTTP URL #33: Adds a test for query_sql and patches HTTP_URL in __main__; closely related as this PR moves query_sql to tool.py and updates test imports and patch targets accordingly.

Poem

In the warren, code hops anew,
Tools now gathered, not scattered through—
From main they leap to tool.py’s den,
With imports neat and tests that pen.
Dependencies stretch their ears up tall,
A modular home for one and all!
🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch tool-refactor

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.